DT-84: Refactor standardize error handling, consolidate frontend logic, and update seed data #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add logs & deployement in seed - LeftPanel only visible from DB tabs - Trace / Span style - Dense log view
abdotop
changed the title
…age in LogsViewer
kigiri
reviewed
Nov 10, 2025
| return data | ||
| if (!res.ok) throw Error(await res.text()) | ||
| return await res.json() | ||
| } |
Member
There was a problem hiding this comment.
class SQLQueryError extends Error {
constructor(message: string, body: string) {
super(message)
this.type = 'unexpected'
this.sqlMessage = 'unexpected error'
try {
const errorDetails = JSON.parse(body)
const errorTypes = ['service-error', 'bad-query', 'timeout']
if (errorTypes.has(errorDetails.type)) this.type = errorDetails.type
if (typeof errorDetails.sqlMessage === 'string') this.sqlMessage = errorDetails.sqlMessage
} catch {
this.sqlMessage = body
}
},
type: 'service-error' | 'bad-query' | 'unexpected' | 'timeout'
sqlMessage: string
}
const body = res.text()
if (res.ok) return JSON.parse(body)
throw new SQLQueryError(`sql endpoint error ${res.status}`, body)
kigiri
reviewed
Nov 10, 2025
web/pages/DeploymentPage.tsx
Outdated
| params={{ expanded: isExpanded ? null : table.table }} | ||
| class='shrink-0' | ||
| class='shrink-0 p-1 hover:bg-base-300 rounded transition-colors flex items-center justify-center' | ||
| onClick={(e) => e.stopPropagation()} |
kigiri
reviewed
Nov 10, 2025
web/lib/shared.tsx
Outdated
| // API signal for current project | ||
| export const project = api['GET/api/project'].signal() | ||
|
|
||
| export const onRun = (query: string) => { |
Member
There was a problem hiding this comment.
export const runQuery = (query?: string) => {
kigiri
reviewed
Nov 10, 2025
web/pages/DeploymentPage.tsx
Outdated
| const handleKeyDown = (e: KeyboardEvent) => { | ||
| if ((e.ctrlKey || e.metaKey) && e.key === 'Enter') { | ||
| e.preventDefault() | ||
| const q = url.params.q |
Member
There was a problem hiding this comment.
// no need to check `runQuery` already does it
runQuery(url.params.q)…pdating its usage in QueryHistory and DeploymentPage components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors across the backend and frontend, focusing on error handling, code organization, and test data seeding. The most notable changes include standardizing error handling in API routes, consolidating shared frontend logic, updating seed data for deployments and logs, and improving type consistency in schemas. These updates enhance maintainability, robustness, and developer experience.