Skip to content

Commit fd8f696

Browse files
rwvoclaude
andcommitted
CI: fix container build — add cmake and ninja-build
The rocm/dev-ubuntu-22.04 base image doesn't include cmake or ninja-build. The old rocm-build image had them via rocm-dev. triton_install.sh needs both for the LLVM build (uses Ninja). Also add set -euo pipefail to build.sh so docker build failures propagate to the caller (previously exited 0 on failure). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 329919e commit fd8f696

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

containers/build.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#!/bin/bash
2+
set -euo pipefail
23

34
# Container name
45
name="omniprobe"

containers/omniprobe.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ WORKDIR /app
1313
RUN apt-get update && \
1414
apt-get install -y software-properties-common && \
1515
apt-get upgrade -y && \
16-
apt-get install -y git build-essential wget clang lld libzstd-dev libomp-dev ccache libdwarf-dev python3-dev && \
16+
apt-get install -y git build-essential cmake ninja-build wget clang lld libzstd-dev libomp-dev ccache libdwarf-dev python3-dev && \
1717
python3 -m pip install --upgrade pip && \
1818
python3 -m pip install --upgrade setuptools
1919

containers/omniprobe.def

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ From: rocm/dev-ubuntu-22.04:{{ ROCM_VERSION }}
3232
apt-get update
3333
apt-get install -y software-properties-common
3434
apt-get upgrade -y
35-
apt-get install -y git build-essential wget clang lld libzstd-dev libomp-dev ccache libdwarf-dev python3-dev
35+
apt-get install -y git build-essential cmake ninja-build wget clang lld libzstd-dev libomp-dev ccache libdwarf-dev python3-dev
3636
python3 -m pip install --upgrade pip
3737
python3 -m pip install --upgrade setuptools
3838

0 commit comments

Comments
 (0)