[Bug]: playback speed changes require 'play' (L) to take effect

[nightgolfer]

What happened?

(maybe this is more like a feature request than a bug)

During playback, when I use SHIFT+I (speed down) or SHIFT+O (speed up) to change playback speed, the 'Speed: 1.2x' indicator updates as expected, but playback speed does not change. When I tap L (playback stops and restarts), the speed updates as expected.

Pausing and resuming via SPACE does not switch to the indicated playback speed.

What did you expect to happen?

A tiny thing, but would be nice if playback speed could be changed (and effected) while audio was playing.

Possible solution:

— When tapping either SHIFT+O or SHIFT+I, start an internal timer (not visible), maybe 2 seconds.
— If SHIFT+O or SHIFT+I is tapped before timer runs out, reset timer (keep running).
— If timer runs out before SHIFT+O or SHIFT+I is tapped, run "play" (like tapping L). Optional: output "updating playback speed" or "playback speed updated" when timer runs out.
— This allows user to shift speed several steps before playback is restarted at correct speed.

Either way, thanks for a cool app! Like this much more than having to run Audiobookshelf in the browser 😃

Steps to reproduce the issue

1. (while paused)
2. SHIFT+O (speed +)
3. speed indicator correctly updates
4. SPACE (play)
5. audio still playing at original speed

or

1. (while playing) SHIFT+O (speed +)
2. speed indicator correctly updates
3. audio still playing at original speed

or

1. (while playing) SHIFT+O (speed +)
2. speed indicator correctly updates
3. audio still playing at original speed
4. SPACE (pause)
5. SPACE (play)
6. audio still playing at original speed

Toutui version

Toutui v0.4.2-beta

Audiobookshelf version

v2.30.0 (docker)

On which OS are you running Toutui?

macOS

How did you install Toutui?

Easy installation (option 1, download the binary)

On which terminal emulator are you running Toutui?

Other

Logs

Logs are not present in ~/.config/toutui/toutui.log. ~/.config/toutui/ doesn't exist. Tried searching, can't find "toutui" folder anywhere on HDD. Not sure where it was installed, used BASH with option 1 in iTerm2.

Panicked/Crash message

No response

Additional Notes

Terminal used: iTerm2 on macOS Monterey 12.6.3 (hackintosh)

[nightgolfer]

Sorry, just read the install notes, found the log files 👍

Nothing in logs relating to playback speed.

[AlbanDAVID]

Hey,
Thank you for your issue.

Ok, I don't have this issue on Linux, it seems to be specific to macOS. Unfortunetly, I don't have so much time now to figure out and fix it for now.

Yes, thank you for the log files, indeed I forgot to specify the directory for macOS in the issue template.

Have good day :)

[nightgolfer]

No worries, I can get around it no problem, just wanted to report 😊