fix(sync): fix infinite sync call from Today page

Author: ArnobChowdhury

src/main/main.ts

@@ -790,6 +790,15 @@ app
         ChannelsEnum.RESPONSE_TOKEN_REFRESHING_FAILED,
       );
     });
+    syncService.initialize({
+      onSyncStatusChange: (isSyncing) => {
+        mainWindow?.webContents.send(
+          ChannelsEnum.RESPONSE_SYNC_STATUS_CHANGE,
+          isSyncing,
+        );
+      },
+    });
+
     createWindow();
     app.on('activate', () => {
       log.info('app activated');

src/main/services/RepetitiveTaskTemplateService.ts

@@ -284,6 +284,8 @@ export class RepetitiveTaskTemplateService {
 
     const isPremium = !!userId;
 
+    let writeOperationOccurred = false;
+
     const processingPromises = dueTemplates.map((template) =>
       prisma.$transaction(async (tx) => {
         const todayStart = dayjs().startOf('day');
@@ -341,6 +343,7 @@ export class RepetitiveTaskTemplateService {
             );
 
             latestDueDateForTemplate = targetDueDate.toDate();
+            writeOperationOccurred = true;
           }
         }
 
@@ -369,7 +372,7 @@ export class RepetitiveTaskTemplateService {
       }
     });
 
-    if (isPremium) {
+    if (isPremium && writeOperationOccurred) {
       syncService.runSync();
     }
   };

src/renderer/context/AppProvider.tsx

@@ -143,26 +143,26 @@ const AppContextFn = (initialUser: User | null) => {
     if (isSyncingRef.current) return;
 
     isSyncingRef.current = true;
-    setIsSyncing(true);
     try {
       await window.electron.ipcRenderer.invoke(ChannelsEnum.REQUEST_SYNC_START);
     } catch (err: any) {
       setNotifier(err.message || 'Sync failed', 'error');
     } finally {
       isSyncingRef.current = false;
-      setIsSyncing(false);
     }
   }, [setNotifier]);
 
   const wasSyncing = useRef(!isSyncing);
   useEffect(() => {
-    window.electron.ipcRenderer.on(
+    // sourcery skip: inline-immediately-returned-variable
+    const unsubscribe = window.electron.ipcRenderer.on(
       ChannelsEnum.RESPONSE_SYNC_STATUS_CHANGE,
       (_isSyncing: unknown) => {
         setIsSyncing(_isSyncing as boolean);
       },
     );
-  });
+    return unsubscribe;
+  }, []);
 
   useEffect(() => {
     if (user && !isSyncing && wasSyncing.current) {