ChordType Overhaul (#47)

* WIP minor major ninth not passing yet

* Added Minor Major Ninth chord type

* Added Major and Dominant Ninth Flat Five refactor of Flat Fifth to Flat Five in all cases

@aure

* WIP on new ranked chords algo

Co-authored-by: Aure <[email protected]>

* New algo working replacing old one

* A few sus chords do not work due to algo being too eager to find thirds via letter

* remade ranked chord algo with interval strategy

* Fixed bug in Note.noteNumber causing infinite loop

Co-authored-by: Aure <[email protected]>

* Added isDouble as computed property to Accidental

* Improved getRankedChords algorithm

Co-authored-by: Aure <[email protected]>

* WIP cleaning up chord list refining examples and descriptions

* test cleanup other typo cleanup

* adding eleventh and thirteenth cases, more to do

* Adding more 13th cases

* WIP Refactoring Chord type case names

Co-authored-by: Aurelius Prochazka <[email protected]>

* WIP: Refactored chord type names

Co-authored-by: Aurelius Prochazka <[email protected]>

* Adding missing 9th and 11th cases

* added missing 13th cases, standardized description notation

* added missing cases for chord font descriptions

* added exhaustive list of sus chords revamping tests

* Don't add chord types if they have already been added

Co-authored-by: Aure <[email protected]>

* omitted 11ths from sus4 13 chords, omitted 9ths from sus2 13 chords

* WIP better tests for new chords

* Allows for all inversions for a given chord

Co-authored-by: Aurelius Prochazka <[email protected]>

* Improved ranking by favoring less complex chords in getRankedChords

Co-authored-by: Aurelius Prochazka <[email protected]>

* Fixed erroneous 13(add11) intervals and formatting

Co-authored-by: Aurelius Prochazka <[email protected]>

* updated tests

Co-authored-by: Aurelius Prochazka <[email protected]>

* Prioritizing hash values from simpler accidentals

Co-authored-by: name <[email protected]>

* [WIP]: Optimizing ordering of chord types by simplicity and/or popularity

Co-authored-by: Aurelius Prochazka <[email protected]>

* Fixed m7 vs M6 spelling with notes initializer

Co-authored-by: Aurelius Prochazka <[email protected]>

* Fixed add9 and 6/9 spelling with notes initializer

Co-authored-by: Aurelius Prochazka <[email protected]>

* chore: formatting

* add deprecated labels for generateAllChord and getAllChordsForNoteSet

* corrected Note init

* tests for dom9flat5, 9sus4, seventh naming, 13th naming

* Fixed various things having to do with the switch to Yamaha standard octave naming

* Fixed tests

* Update tests to macos-13

---------

Co-authored-by: Aure <[email protected]>

Author: maksutovic

.github/workflows/tests.yml

@@ -21,7 +21,7 @@ jobs:
     name: Build ${{ matrix.scheme }} (Xcode ${{ matrix.xcode_version }})
     # NOTE: macos-latest is NOT equivalent to macos-12 as of September 2022.
     # Source: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
-    runs-on: macos-12
+    runs-on: macos-13
     needs: [swift_test]
     strategy:
       # Disabling fail-fast ensures that the job will run all configurations of the matrix, even if one fails.