Skip to content

Conversation

@JsGjKJzi
Copy link
Contributor

Describe your changes

This adds the larod-sys crate as an initial step to adding a later larod crate.

The larod-sys crate contains mainly the code needed for bindgen to generate Rust wrappers around the larod.h header file. The few exceptions are where enums or constants are defined by function style C macros that bindgen does not handle. These enums or constants are defined manually in the larod-sys/src/lib.rs file.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@JsGjKJzi JsGjKJzi requested a review from a team as a code owner April 20, 2025 02:19
@JsGjKJzi
Copy link
Contributor Author

@apljungquist I'm getting some time again to work on this so trying to merge things in piecemeal. As you mentioned, enough changed between main and the prior Add Larod PR that I think it makes sense to pull smaller chunks of code out of that PR and merge them in individually.

@apljungquist
Copy link
Collaborator

Nice! I'd like to take time to understand and do a proper review, but let's see how that goes - the amount of time I can dedicate to this project is significantly reduced since I left Axis. But if I can't make time then at least I will try to get out of your way so we can get this contribution merged; together with VDO it is in my opinion the most important missing piece in the ACAP+Rust puzzle.

@apljungquist apljungquist mentioned this pull request Apr 21, 2025
6 tasks
apljungquist
apljungquist previously approved these changes Apr 23, 2025
Because it is no longer used
Something needs to compile the sys crate for the requested target or the make target for the bindings file will not work.
Something is weird with this app, I consistently get the wrong checksum locally
@apljungquist apljungquist requested a review from guoxe May 7, 2025 19:22
apljungquist
apljungquist previously approved these changes May 7, 2025
@apljungquist apljungquist merged commit 76b00ea into AxisCommunications:main May 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants