Remove Private Decorator in StorageActions (#36905)

* update

* remove  suppression in model

* removed suppression

---------

Co-authored-by: Pan Shao <[email protected]>

Author: mcgallan

specification/storageactions/StorageAction.Management/StorageTask.tsp

@@ -13,12 +13,8 @@ namespace Microsoft.StorageActions;
 /**
  * Represents Storage Task.
  */
-#suppress "@azure-tools/typespec-azure-core/no-private-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
-#suppress "@azure-tools/typespec-azure-core/no-private-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
-#suppress "@azure-tools/typespec-azure-core/composition-over-inheritance" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
-@Azure.ResourceManager.Private.armResourceInternal(StorageTaskProperties)
-@Http.Private.includeInapplicableMetadataInPayload(false)
-model StorageTask extends Foundations.TrackedResource {
+model StorageTask
+  is Azure.ResourceManager.TrackedResource<StorageTaskProperties, false> {
   ...ResourceNameParameter<
     Resource = StorageTask,
     KeyName = "storageTaskName",
@@ -31,12 +27,6 @@ model StorageTask extends Foundations.TrackedResource {
    */
   #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
   identity: Azure.ResourceManager.Foundations.ManagedServiceIdentity;
-
-  #suppress "@azure-tools/typespec-azure-core/no-private-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
-  #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
-  @doc("The resource-specific properties for this resource.")
-  @Azure.ResourceManager.Private.armResourcePropertiesOptionality(false)
-  properties?: StorageTaskProperties;
 }
 
 @armResourceOperations

specification/storageactions/StorageAction.Management/models.tsp

@@ -116,7 +116,6 @@ model StorageTaskPreviewAction {
   /**
    * Properties of the storage task preview.
    */
-  #suppress "@azure-tools/typespec-azure-core/no-private-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
   properties: StorageTaskPreviewActionProperties;
 }
 
@@ -387,7 +386,6 @@ model StorageTaskUpdateParameters {
   /**
    * Properties of the storage task.
    */
-  #suppress "@azure-tools/typespec-azure-core/no-private-usage" "FIXME: Update justification, follow aka.ms/tsp/conversion-fix for details"
   properties?: StorageTaskUpdateProperties;
 }
 

specification/storageactions/resource-manager/Microsoft.StorageActions/stable/2023-01-01/storageactions.json

@@ -828,19 +828,19 @@
       "type": "object",
       "description": "Represents Storage Task.",
       "properties": {
-        "identity": {
-          "$ref": "../../../../../common-types/resource-management/v5/managedidentity.json#/definitions/ManagedServiceIdentity",
-          "description": "The managed service identity of the resource."
-        },
         "properties": {
           "$ref": "#/definitions/StorageTaskProperties",
           "description": "Properties of the storage task.",
           "x-ms-client-flatten": true
+        },
+        "identity": {
+          "$ref": "../../../../../common-types/resource-management/v5/managedidentity.json#/definitions/ManagedServiceIdentity",
+          "description": "The managed service identity of the resource."
         }
       },
       "required": [
-        "identity",
-        "properties"
+        "properties",
+        "identity"
       ],
       "allOf": [
         {