-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Handle MsalRuntime Error Surfacing #8120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ugonnaak1
wants to merge
17
commits into
dev
Choose a base branch
from
errorSurfacing
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+274
−147
Open
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8816254
error surfacing changes
Ugonnaak1 700cc10
Change files
Ugonnaak1 6c4ccd0
Merge branch 'dev' into errorSurfacing
Ugonnaak1 dd76def
api changes
Ugonnaak1 3b53bff
move nativeautherror and strilutils to msal/common
Ugonnaak1 1e4998e
api changes
Ugonnaak1 fabe8d4
Merge branch 'dev' into errorSurfacing
Ugonnaak1 b8e45fc
create clone
Ugonnaak1 3ab0162
rename NativeAuthError
Ugonnaak1 f52b105
move tagtoStirng under PlatformBrokerError
Ugonnaak1 9eb03bd
Merge branch 'dev' into errorSurfacing
Ugonnaak1 f679480
api changes
Ugonnaak1 d9aa857
Merge branch 'dev' into errorSurfacing
Ugonnaak1 38f4a2e
fix format
Ugonnaak1 57373dd
Merge branch 'dev' into errorSurfacing
Ugonnaak1 827ac7e
address comments
Ugonnaak1 2d93ac4
api doc changes
Ugonnaak1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@azure-msal-common-fa718400-1f30-4ec0-a922-9ab96a7fe335.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "error surfacing changes", | ||
| "packageName": "@azure/msal-common", | ||
| "email": "[email protected]", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@azure-msal-node-extensions-05784d6a-75fa-4bbf-adf4-543636d3ae42.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "error surfacing changes", | ||
| "packageName": "@azure/msal-node-extensions", | ||
| "email": "[email protected]", | ||
| "dependentChangeType": "patch" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* | ||
| * Copyright (c) Microsoft Corporation. All rights reserved. | ||
| * Licensed under the MIT License. | ||
| */ | ||
|
|
||
| import { AuthError } from "./AuthError.js"; | ||
|
|
||
| /** | ||
| * Error class for MSAL Runtime errors that preserves detailed broker information | ||
| */ | ||
| export class NativeAuthError extends AuthError { | ||
Ugonnaak1 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| /** | ||
| * Numeric error code from MSAL Runtime | ||
| */ | ||
| public statusCode: number; | ||
|
|
||
| /** | ||
| * Error tag from MSAL Runtime | ||
| */ | ||
| public tag: string; | ||
|
|
||
| constructor( | ||
| errorStatus: string, | ||
| errorContext: string, | ||
| errorCode: number, | ||
| errorTag: number | ||
| ) { | ||
| super(errorStatus, errorContext); | ||
| this.name = "NativeAuthError"; | ||
| this.statusCode = errorCode; | ||
| this.tag = errorTag.toString(); | ||
| Object.setPrototypeOf(this, NativeAuthError.prototype); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.