Use non-fallible conversion in display page to create string of contents

Author: BBaoVanC

CHANGELOG.md

@@ -24,6 +24,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   before starting web server
   - This feels a bit nicer because there's no need to reference count a type
     which must live for the entire program anyways.
+- Don't potentially try to create a string with `usize::MAX` capacity when
+  displaying a file
+  - Pretty sure that since all relevant (>= 32 bits) platforms can fit 1048576
+    in a usize, that this bug would never actually happen. But it shouldn't
+    exist in the code.
 
 ## [v0.2.12] - 2024-11-04
 

bobashare-web/src/views/display.rs

@@ -140,7 +140,9 @@ pub async fn display(
                         .syntax_set
                         .find_syntax_by_extension(extension)
                         .unwrap_or_else(|| state.syntax_set.find_syntax_plain_text());
-                    let mut contents = String::with_capacity(size.try_into().unwrap_or(usize::MAX));
+                    // should be alright to assume that 1,048,576 fits in usize on relevant
+                    // platforms
+                    let mut contents = String::with_capacity(size as usize);
                     upload
                         .file
                         .read_to_string(&mut contents)