test: address review feedback on Tier 1 test suite

- Fix env.test.ts test names that incorrectly claimed to test defaults
  while .env.test was setting those vars explicitly
- Assert exact value for PUBLIC_WALLETCONNECT_PROJECT_ID (was typeof check)
- Fix createMockWeb3Status shape to match actual Web3Status interface
  (was using isConnected/chainId/publicClient; hook uses isWalletConnected/
  walletChainId/readOnlyClient)
- Hardcode expected explorer URL in getExplorerLink assertions instead of
  deriving from mock chain (prevents false positives if mock misconfigured)

Author: gabitoesmiapodo

src/env.test.ts

@@ -11,8 +11,8 @@ describe('env', () => {
     expect(env.PUBLIC_APP_NAME).toBe('dAppBooster Test')
   })
 
-  it('defaults PUBLIC_NATIVE_TOKEN_ADDRESS to zero address when not set', () => {
-    // .env.test sets it to the zero address explicitly
+  it('reads and normalizes PUBLIC_NATIVE_TOKEN_ADDRESS from env', () => {
+    // .env.test sets it to the zero address; the schema lowercases the value
     expect(env.PUBLIC_NATIVE_TOKEN_ADDRESS).toBe(zeroAddress.toLowerCase())
   })
 
@@ -32,17 +32,18 @@ describe('env', () => {
     expect(env.PUBLIC_INCLUDE_TESTNETS).toBe(true)
   })
 
-  it('defaults PUBLIC_SUBGRAPHS_ENVIRONMENT to production', () => {
+  it('reads PUBLIC_SUBGRAPHS_ENVIRONMENT from test env', () => {
+    // .env.test sets it to 'production'; to test the schema default use vi.resetModules()
     expect(env.PUBLIC_SUBGRAPHS_ENVIRONMENT).toBe('production')
   })
 
   it('exposes PUBLIC_SUBGRAPHS_API_KEY from test env', () => {
     expect(env.PUBLIC_SUBGRAPHS_API_KEY).toBe('test-api-key')
   })
 
-  it('exposes PUBLIC_WALLETCONNECT_PROJECT_ID with empty string default', () => {
+  it('exposes PUBLIC_WALLETCONNECT_PROJECT_ID from test env', () => {
     // .env.test sets it to 'test-project-id'
-    expect(typeof env.PUBLIC_WALLETCONNECT_PROJECT_ID).toBe('string')
+    expect(env.PUBLIC_WALLETCONNECT_PROJECT_ID).toBe('test-project-id')
   })
 
   it('optional RPC vars are undefined when not set in test env', () => {

src/test-utils.tsx

@@ -22,16 +22,21 @@ export function createMockWeb3Status(overrides?: Partial<ReturnType<typeof _mock
 
 function _mockShape() {
   return {
+    // AppWeb3Status
+    readOnlyClient: undefined,
+    appChainId: 1 as number,
+    // WalletWeb3Status
     address: undefined as `0x${string}` | undefined,
-    isConnected: false,
-    isConnecting: false,
-    isDisconnected: true,
-    chainId: undefined as number | undefined,
     balance: undefined,
-    publicClient: undefined,
+    connectingWallet: false,
+    switchingChain: false,
+    isWalletConnected: false,
     walletClient: undefined,
+    isWalletSynced: false,
+    walletChainId: undefined as number | undefined,
+    // Web3Actions
     disconnect: () => {},
-    switchChain: undefined,
+    switchChain: (_chainId?: number) => {},
   }
 }
 

src/utils/getExplorerLink.test.ts

@@ -12,12 +12,12 @@ const txHash = '0xd85ef8c70dc31a4f8d5bf0331e1eac886935905f15d32e71b348df745cd38e
 describe('getExplorerLink', () => {
   it('returns address URL using chain block explorer', () => {
     const url = getExplorerLink({ chain, hashOrAddress: address })
-    expect(url).toBe(`${chain.blockExplorers?.default.url}/address/${address}`)
+    expect(url).toBe(`https://mock.explorer.url/address/${address}`)
   })
 
   it('returns tx URL using chain block explorer for a hash', () => {
     const url = getExplorerLink({ chain, hashOrAddress: txHash })
-    expect(url).toBe(`${chain.blockExplorers?.default.url}/tx/${txHash}`)
+    expect(url).toBe(`https://mock.explorer.url/tx/${txHash}`)
   })
 
   it('uses custom explorerUrl for an address', () => {