-
Notifications
You must be signed in to change notification settings - Fork 8
[6주차] Team CatchUp 정성훈&장자윤 과제 제출합니다. #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
darkyam
wants to merge
85
commits into
CEOS-Developers:main
Choose a base branch
from
CEOS-22nd-CatchUP:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
4d0e328
Initial commit from Create Next App
Jy000n 10cbb05
initial commit
Jy000n 46e0b4f
fix: merge 충돌 해결
Jy000n 546c15e
Merge branch 'main' of https://github.com/CEOS-22nd-CatchUP/next-netf…
Jy000n 8ff8860
feat: svgr 추가
Jy000n 6f22912
feat: 이미지 파일 추가(+fill 속성 변경)
Jy000n 85b066b
feat: src 절대경로 지정
Jy000n ecedb6f
feat: 폰트, 스타일 추가
Jy000n 0889e7a
feat: 와이어프레임 UI
Jy000n 45a21df
feat: slick-carousel 추가
darkyam 312a4bf
fix: next에서 tmdb이미지 사용허용
darkyam 8d6e2ea
feat: movie 타입 정의
darkyam 4814114
feat: 이미지 carousel 구현
darkyam 110ad82
feat: 인기영화 api 호출 추가
darkyam e4ed1f7
chore: carousel css import
darkyam 4250395
design: TopMenubar css 수정
darkyam 119816f
feat: 영화 carousel 구현
darkyam 12e617b
design: 메뉴바 css 수정
darkyam b4abd0b
style: 기타 수정
darkyam a5c2898
feat: api 호출해 현재 영화 이미지 추가 구현
darkyam 09e4396
feat: carousel 추가
darkyam 50946f3
fix: math.random 함수 오류 수정
darkyam b54aeae
feat: svg 컴포넌트화
Jy000n 992e464
feat: 장르별 영화정보 api 호출 추가
darkyam e968602
feat: 큰 사이즈 carousel 추가
darkyam 81fc5eb
chore: 자잘한 수정
darkyam 4d3e07d
feat: 장르별 carousel 추가
darkyam 6d47909
feat: BtmMenubar UI
Jy000n 999a155
import {IconProps} from '@/type/menu.type';
Jy000n 0ba6d50
fix: TheOthers.tsx 파일 async() 관련 에러로 인한 주석처리+코드수정
Jy000n 113c42e
feat: BtmMenubar 클릭 UI
Jy000n f696d37
feat: prettierrc 설정 적용 수정 완료
Jy000n 1e47751
feat: landing 페이지 인트로 완료
Jy000n 113c549
style: IntroLogo 스타일 수정
Jy000n 386d337
feat: main 페이지 skeleton UI
Jy000n c10f403
style: 메뉴바 px 고정 해제
Jy000n fb0d65b
style: 전체적 스타일 수정
Jy000n 1b77237
feat: 메인페이지 currentPlaying 이미지 그라데이션 추가
Jy000n ca1b546
feat: TOP10 이미지->text로 변경
Jy000n b6bcaca
feat: zustand 상태관리 이용한 btmMenubar 페이지 이동
Jy000n 2f1e1fe
perf: 서버-클라이언트 컴포넌트 렌더링 최적화
Jy000n 16a9724
fix: 이미지 컴포넌트 속성 lowerCamelCase로 변경
Jy000n eb9c5db
fix: alt 삭제
darkyam fc3b8ad
fix: svg타입 에러 수정
darkyam 6e07809
rename: 파일명 수정
Jy000n 27d10e1
Merge branch 'main' of https://github.com/CEOS-22nd-CatchUP/next-netf…
Jy000n e37a8dd
fix: svg 타입 오류 수정
darkyam 3d85159
feat: midNavbar Items 이미지 컴포넌트화
Jy000n 2ef55b2
fix: MidNavbar 이미지 컴포넌트화 merge 충돌 해결
Jy000n 661c4ab
feat: MidNavbar 텍스트 추가
Jy000n 6eb30ef
refactor: 폴더 구조 정리
Jy000n 6d1aedc
refactor: Genre.tsx 폴더 위치 변경
Jy000n 702f718
feat: smallLogo 이미지 컴포넌트화
Jy000n d4fa4fd
fix: svg 경로 수정
darkyam 3e872d4
refactor: components 폴더 구조 변경
Jy000n 2344474
Merge branch 'main' of https://github.com/CEOS-22nd-CatchUP/next-netf…
Jy000n 586a971
fix: merge
Jy000n e8e183e
refactor: font, svgs 파일 위치 변경
Jy000n fa4a888
refactor: type.ts 파일 -> d.ts 파일로 변경
Jy000n 0018d34
refactor: 코드리뷰 반영
Jy000n 1bca956
feat: 검색페이지 UI
Jy000n e59c8fc
feat: 검색페이지 스켈레톤 UI
Jy000n 724dd06
feat: 영화 상세정보 호출 api 작성
darkyam 2af4b21
feat: 영화 상세정보페이지 layout 작성
darkyam ef57d1a
feat:영화 상세정보 페이지 구현
darkyam 729745d
feat: carousel 클릭 시 해당 영화 페이지로 이동
darkyam f83ab9f
fix: css 오타 수정
darkyam 88a5109
style: 절대경로로 변경
darkyam ab3e1cd
feat: movie 페이지에서도 BtmNavbar 보이게 수정
darkyam 687bd54
fix: api 클라이언트에서도 사용할 수 있게 수정
darkyam 23b8a4f
feat: seach페이지 인기영화 처음에 띄우는 기능 추가
darkyam 78e1a97
feat: 검색 input 구현
darkyam c8f5178
feat: 검색 결과 리스트 구현
darkyam cbf3625
feat: 검색 상태 store 추가
darkyam deeeced
fix: api csr에서 호출되게 수정
darkyam c35a3c7
fix: prop 삭제
darkyam 6f18432
feat: 무한스크롤 구현
darkyam e89fb6a
feat: 검색페이지 검색 결과 없을 때 렌더링
Jy000n 0519d6d
feat: 검색페이지 무한스크롤 중 스켈레톤 UI 추가 + 처음 렌더링 후 스켈레톤 UI 수정
Jy000n 4d7eba3
feat: 상세정보 페이지 스켈레톤 UI
Jy000n 73b4aa3
feat: 검색페이지 입력값 존재X/초기화 시 initial(popular movies) rendering
Jy000n 5f186ab
style: 전체적 css 스타일 수정
Jy000n 246f4d8
fix: 검색페이지 2번 렌더링 문제 수정
Jy000n e02838c
refactor: tmdb.ts 파일 libs 폴더로 이동
Jy000n d91ee33
style: 주석 제거, 엔터 등 코드 전체적 정리
Jy000n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "plugins": ["prettier"], | ||
| "extends": ["eslint:recommended", "plugin:prettier/recommended"], | ||
| "rules": { | ||
| "prettier/prettier": "error" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | ||
|
|
||
| # dependencies | ||
| /node_modules | ||
| /.pnp | ||
| .pnp.* | ||
| .yarn/* | ||
| !.yarn/patches | ||
| !.yarn/plugins | ||
| !.yarn/releases | ||
| !.yarn/versions | ||
|
|
||
| # testing | ||
| /coverage | ||
|
|
||
| # next.js | ||
| /.next/ | ||
| /out/ | ||
|
|
||
| # production | ||
| /build | ||
|
|
||
| # misc | ||
| .DS_Store | ||
| *.pem | ||
|
|
||
| # debug | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| .pnpm-debug.log* | ||
|
|
||
| # env files (can opt-in for committing if needed) | ||
| .env* | ||
|
|
||
| # vercel | ||
| .vercel | ||
|
|
||
| # typescript | ||
| *.tsbuildinfo | ||
| next-env.d.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "arrowParens": "always", | ||
| "bracketSpacing": true, | ||
| "endOfLine": "lf", | ||
| "printWidth": 120, | ||
| "semi": true, | ||
| "singleQuote": true, | ||
| "tabWidth": 2, | ||
| "trailingComma": "all", | ||
| "useTabs": false, | ||
| "plugins": ["prettier-plugin-tailwindcss"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { defineConfig, globalIgnores } from "eslint/config"; | ||
| import nextVitals from "eslint-config-next/core-web-vitals"; | ||
| import nextTs from "eslint-config-next/typescript"; | ||
|
|
||
| const eslintConfig = defineConfig([ | ||
| ...nextVitals, | ||
| ...nextTs, | ||
| // Override default ignores of eslint-config-next. | ||
| globalIgnores([ | ||
| // Default ignores of eslint-config-next: | ||
| ".next/**", | ||
| "out/**", | ||
| "build/**", | ||
| "next-env.d.ts", | ||
| ]), | ||
| ]); | ||
|
|
||
| export default eslintConfig; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import type { NextConfig } from 'next'; | ||
|
|
||
| const nextConfig: NextConfig = { | ||
| images: { | ||
| remotePatterns: [ | ||
| { | ||
| protocol: 'https', | ||
| hostname: 'image.tmdb.org', | ||
| port: '', | ||
| pathname: '/t/p/**', | ||
| }, | ||
| ], | ||
| }, | ||
| }; | ||
|
|
||
| export default nextConfig; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개인적으로 그냥 궁금한 점인데 prettier 코드도 두분이 합의를 보셨나요?? 저희는 안했는데 다른팀은 어떻게 했는지 궁금하네요