fix(resource-information): fixed comments

Author: nsemets

package-lock.json

@@ -72,14 +72,6 @@ describe('ResourceInformationDialogComponent', () => {
     });
   });
 
-  it('should not close dialog on save when form is invalid', () => {
-    component.resourceForm.setErrors({ invalid: true });
-
-    component.save();
-
-    expect(dialogRef.close).not.toHaveBeenCalled();
-  });
-
   it('should close dialog without payload on cancel', () => {
     component.cancel();
 

src/app/features/metadata/dialogs/resource-information-dialog/resource-information-dialog.component.spec.ts

@@ -42,13 +42,11 @@ export class ResourceInformationDialogComponent implements OnInit {
   }
 
   save(): void {
-    if (this.resourceForm.valid) {
-      const formValue = this.resourceForm.getRawValue();
-      this.dialogRef.close({
-        resourceTypeGeneral: formValue.resourceType,
-        language: formValue.resourceLanguage,
-      });
-    }
+    const formValue = this.resourceForm.getRawValue();
+    this.dialogRef.close({
+      resourceTypeGeneral: formValue.resourceType,
+      language: formValue.resourceLanguage,
+    });
   }
 
   cancel(): void {

src/app/features/metadata/dialogs/resource-information-dialog/resource-information-dialog.component.ts

@@ -1,6 +1,8 @@
 @let resource = currentProject();
 
 @if (resource) {
+  @let customMetadata = customItemMetadata();
+
   <div class="metadata flex flex-column gap-5">
     <div class="metadata-header flex align-items-center justify-content-between">
       <h2>{{ 'common.labels.metadata' | translate }}</h2>
@@ -33,8 +35,8 @@ <h3>{{ 'project.overview.metadata.resourceType' | translate }}</h3>
 
       <p data-test-project-overview-metadata-resource-type>
         {{
-          customItemMetadata()?.resourceTypeGeneral
-            ? (customItemMetadata()?.resourceTypeGeneral | resourceTypeGeneralLabel)
+          customMetadata?.resourceTypeGeneral
+            ? (customMetadata?.resourceTypeGeneral | resourceTypeGeneralLabel)
             : ('project.overview.metadata.noResourceType' | translate)
         }}
       </p>
@@ -98,16 +100,16 @@ <h3>{{ 'project.overview.metadata.supplements' | translate }}</h3>
     <div class="flex flex-column gap-2">
       <h3>{{ 'project.overview.metadata.funderNames' | translate }}</h3>
 
-      <osf-funders-list [funders]="customItemMetadata()?.funders" [isLoading]="isCustomItemMetadataLoading()" />
+      <osf-funders-list [funders]="customMetadata?.funders" [isLoading]="isCustomItemMetadataLoading()" />
     </div>
 
     <div class="flex flex-column gap-2">
       <h3>{{ 'common.labels.language' | translate }}</h3>
 
       <p data-test-project-overview-metadata-resource-language>
         {{
-          customItemMetadata()?.language
-            ? (customItemMetadata()?.language | languageLabel)
+          customMetadata?.language
+            ? (customMetadata?.language | languageLabel)
             : ('project.overview.metadata.noLanguage' | translate)
         }}
       </p>