[ENG-10275] [ENG-10802] OSF4I In-progress SSO - FE Piece (#967)

* fixed login url encoding
* unified encoding of login
* Update logout url
* Add sso_availability attribute to Institution model and mapper
* simplify login url construction and remove helper
* fix institution unit tests
* update logout redirect url to ensure proper navigation

---------

Co-authored-by: Ihor Sokhan <isokhan@exoft.net>
Co-authored-by: nsemets <nsemets@exoft.net>
Co-authored-by: Vlad0n20 <vlad.onischuk1234@gmail.com>
Co-authored-by: Longze Chen <cslzchen@gmail.com>

Author: 5 people

src/app/core/services/auth.service.ts

@@ -41,8 +41,14 @@ export class AuthService {
     }
 
     this.loaderService.show();
-    const loginUrl = `${this.casUrl}/login?${urlParam({ service: `${this.webUrl}/login`, next: window.location.href })}`;
-    window.location.href = loginUrl;
+
+    const serviceUrl = new URL(`${this.webUrl}/login`);
+    serviceUrl.searchParams.set('next', window.location.href);
+
+    const loginUrl = new URL(`${this.casUrl}/login`);
+    loginUrl.searchParams.set('service', serviceUrl.toString());
+
+    window.location.href = loginUrl.toString();
   }
 
   navigateToOrcidSignIn(): void {
@@ -79,7 +85,7 @@ export class AuthService {
 
     if (isPlatformBrowser(this.platformId)) {
       this.cookieService.deleteAll();
-      window.location.href = `${this.webUrl}/logout/?next=${encodeURIComponent(nextUrl || '/')}`;
+      window.location.href = `${this.webUrl}/logout/?next=${encodeURIComponent(nextUrl || `${window.location.origin}/`)}`;
     }
   }
 

src/app/features/profile/components/profile-information/profile-information.component.spec.ts

@@ -37,6 +37,7 @@ describe('ProfileInformationComponent', () => {
       },
       institutionalRequestAccessEnabled: true,
       logoPath: 'logo.png',
+      sso_availability: 'Public',
     },
   ];
 

src/app/features/project/overview/components/add-component-dialog/add-component-dialog.component.spec.ts

@@ -64,6 +64,7 @@ describe('AddComponentDialogComponent', () => {
       assets: { logo: '', logo_rounded: '', banner: '' },
       institutionalRequestAccessEnabled: false,
       logoPath: '',
+      sso_availability: 'Public',
     },
     {
       id: 'inst-2',
@@ -76,6 +77,7 @@ describe('AddComponentDialogComponent', () => {
       assets: { logo: '', logo_rounded: '', banner: '' },
       institutionalRequestAccessEnabled: false,
       logoPath: '',
+      sso_availability: 'Public',
     },
   ];
 
@@ -91,6 +93,7 @@ describe('AddComponentDialogComponent', () => {
       assets: { logo: '', logo_rounded: '', banner: '' },
       institutionalRequestAccessEnabled: false,
       logoPath: '',
+      sso_availability: 'Public',
     },
   ];
 

src/app/shared/components/affiliated-institution-select/affiliated-institution-select.component.spec.ts

@@ -68,6 +68,7 @@ describe('AffiliatedInstitutionSelectComponent', () => {
       },
       institutionalRequestAccessEnabled: false,
       logoPath: '/logos/unavailable.png',
+      sso_availability: 'Unavailable',
     };
 
     fixture.componentRef.setInput('institutions', mockInstitutions);
@@ -134,6 +135,7 @@ describe('AffiliatedInstitutionSelectComponent', () => {
       },
       institutionalRequestAccessEnabled: false,
       logoPath: '/logos/unavailable.png',
+      sso_availability: 'Unavailable',
     };
 
     fixture.componentRef.setInput('institutions', mockInstitutions);
@@ -181,6 +183,7 @@ describe('AffiliatedInstitutionSelectComponent', () => {
       },
       institutionalRequestAccessEnabled: false,
       logoPath: '/logos/unavailable.png',
+      sso_availability: 'Unavailable',
     };
 
     fixture.componentRef.setInput('institutions', mockInstitutions);

src/app/shared/mappers/institutions/institutions.mapper.ts

@@ -25,6 +25,7 @@ export class InstitutionsMapper {
       logoPath: data.attributes.logo_path,
       userMetricsUrl: data.relationships?.user_metrics?.links?.related?.href,
       linkToExternalReportsArchive: data.attributes.link_to_external_reports_archive,
+      sso_availability: data.attributes.sso_availability,
     };
   }
 

src/app/shared/models/institutions/institution-json-api.model.ts

@@ -23,6 +23,7 @@ interface InstitutionAttributesJsonApi {
   institutional_request_access_enabled: boolean;
   logo_path: string;
   link_to_external_reports_archive: string;
+  sso_availability: string;
 }
 
 interface InstitutionLinksJsonApi {

src/app/shared/models/institutions/institutions.model.ts

@@ -16,6 +16,7 @@ export interface Institution {
   logoPath: string;
   userMetricsUrl?: string;
   linkToExternalReportsArchive?: string;
+  sso_availability: string;
 }
 
 export interface InstitutionAssets {

src/testing/mocks/institution.mock.ts

@@ -13,4 +13,5 @@ export const MOCK_INSTITUTION = {
   },
   institutionalRequestAccessEnabled: true,
   logoPath: 'https://mockinstitution.org/logo.png',
+  sso_availability: 'Public',
 };