-
Notifications
You must be signed in to change notification settings - Fork 85
Add Stellar namespace CAIP-10 and CAIP-19 specifications #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| ### Issued Assets | ||
|
|
||
| Issued assets are created by issuers and must be explicitly trusted by recipients before they can be received. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a little ambiguous-- is it the asset or the issuer that must be explicitly "trusted" before being received? i'm a little unclear on whether this is a UX thing (wallets MUST get user consent) or a TXN-level trust attestation or a mysterious third thing-- in any case, probably warrants another sentence!
These all seem entirely defensible, but just in case, could you maybe tag some Stellar devs for a review just in case these decisions are controversial among devs who would implement this some day, whether on a CEX or a wallet or another kind of dapp? |
bumblefudge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me though extra credit for a review from someone with stellar opinions!
obstropolos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to approve this as a draft.
We can tag some Stellar folks for additional eyes wherever, but otherwise looks great.
Thanks @pelle!
Summary
This PR adds comprehensive Chain Agnostic Improvement Proposal (CAIP) specifications for the Stellar namespace:
CAIP-10: Stellar Addresses
Address Formats Supported
Classic G-addresses (56 characters)
Muxed M-addresses (69 characters)
Key Features
CAIP-19: Stellar Assets
Asset Types Covered
Native Asset (
slip44:148)Issued Assets (
asset){asset_code}-{issuer_address}using hyphen delimiterLiquidity Pool Shares (
cap38)Soroban Contract Tokens (
sep41)Design Decisions
assetnamespace for simplicity-instead of:to separate asset code from issuer addresscap38andsep41to directly reference the defining protocol specificationsComprehensive Coverage