Merge pull request #3944 from CliMA/aj/cloud_fraction

Materialize a lazy function to fix coupler test

Author: szy21

src/cache/cloud_fraction.jl

@@ -94,7 +94,9 @@ NVTX.@annotate function set_cloud_fraction!(
         end
     end
 
-    ᶜmixing_length = compute_gm_mixing_length(Y, p)
+    # TODO - tmp fix for the Coupler test. To be removed soon.
+    ᶜmixing_length_field = p.scratch.ᶜtemp_scalar
+    ᶜmixing_length_field .= compute_gm_mixing_length(Y, p)
 
     diagnostic_covariance_coeff = CAP.diagnostic_covariance_coeff(params)
     @. cloud_diagnostics_tuple = quad_loop(
@@ -103,7 +105,7 @@ NVTX.@annotate function set_cloud_fraction!(
         Geometry.WVector(p.precomputed.ᶜgradᵥ_q_tot),
         Geometry.WVector(p.precomputed.ᶜgradᵥ_θ_liq_ice),
         diagnostic_covariance_coeff,
-        ᶜmixing_length,
+        ᶜmixing_length_field,
         thermo_params,
     )
 end