use 0 instead of zero(field) in broadcasts

Author: juliasloan25

experiments/ClimaEarth/components/land/climaland_integrated.jl

@@ -607,10 +607,8 @@ function FluxCalculator.compute_surface_fluxes!(
     )
 
     # Zero out the fluxes where the area fraction is zero
-    @. csf.scalar_temp1 =
-        ifelse(area_fraction == 0, zero(csf.scalar_temp1), csf.scalar_temp1)
-    @. csf.scalar_temp2 =
-        ifelse(area_fraction == 0, zero(csf.scalar_temp2), csf.scalar_temp2)
+    @. csf.scalar_temp1 = ifelse(area_fraction == 0, 0, csf.scalar_temp1)
+    @. csf.scalar_temp2 = ifelse(area_fraction == 0, 0, csf.scalar_temp2)
 
     # Update the coupler field in-place
     @. csf.F_lh += csf.scalar_temp1 * area_fraction
@@ -628,8 +626,7 @@ function FluxCalculator.compute_surface_fluxes!(
             p.snow.snow_cover_fraction .* snow_dest.vapor_flux
         ) .* ρ_liq,
     )
-    @. csf.scalar_temp1 =
-        ifelse(area_fraction == 0, zero(csf.scalar_temp1), csf.scalar_temp1)
+    @. csf.scalar_temp1 = ifelse(area_fraction == 0, 0, csf.scalar_temp1)
     @. csf.F_turb_moisture += csf.scalar_temp1 * area_fraction
 
     # Combine turbulent momentum fluxes from each component of the land model
@@ -640,17 +637,15 @@ function FluxCalculator.compute_surface_fluxes!(
         soil_dest.ρτxz .* (1 .- p.snow.snow_cover_fraction) .+
         p.snow.snow_cover_fraction .* snow_dest.ρτxz,
     )
-    @. csf.scalar_temp1 =
-        ifelse(area_fraction == 0, zero(csf.scalar_temp1), csf.scalar_temp1)
+    @. csf.scalar_temp1 = ifelse(area_fraction == 0, 0, csf.scalar_temp1)
     @. csf.F_turb_ρτxz += csf.scalar_temp1 * area_fraction
 
     Interfacer.remap!(
         csf.scalar_temp1,
         soil_dest.ρτyz .* (1 .- p.snow.snow_cover_fraction) .+
         p.snow.snow_cover_fraction .* snow_dest.ρτyz,
     )
-    @. csf.scalar_temp1 =
-        ifelse(area_fraction == 0, zero(csf.scalar_temp1), csf.scalar_temp1)
+    @. csf.scalar_temp1 = ifelse(area_fraction == 0, 0, csf.scalar_temp1)
     @. csf.F_turb_ρτyz += csf.scalar_temp1 * area_fraction
 
     # Combine the buoyancy flux from each component of the land model
@@ -661,15 +656,13 @@ function FluxCalculator.compute_surface_fluxes!(
         soil_dest.buoy_flux .* (1 .- p.snow.snow_cover_fraction) .+
         p.snow.snow_cover_fraction .* snow_dest.buoy_flux,
     )
-    @. csf.scalar_temp1 =
-        ifelse(area_fraction == 0, zero(csf.scalar_temp1), csf.scalar_temp1)
+    @. csf.scalar_temp1 = ifelse(area_fraction == 0, 0, csf.scalar_temp1)
     @. csf.buoyancy_flux += csf.scalar_temp1 * area_fraction
 
     # Compute ustar from the momentum fluxes and surface air density
     #  ustar = sqrt(ρτ / ρ)
     @. csf.scalar_temp1 = sqrt(sqrt(csf.F_turb_ρτxz^2 + csf.F_turb_ρτyz^2) / csf.ρ_atmos)
-    @. csf.scalar_temp1 =
-        ifelse(area_fraction == 0, zero(csf.scalar_temp1), csf.scalar_temp1)
+    @. csf.scalar_temp1 = ifelse(area_fraction == 0, 0, csf.scalar_temp1)
     # If ustar is zero, set it to eps to avoid division by zero in the atmosphere
     @. csf.ustar += max(csf.scalar_temp1 * area_fraction, eps(FT))
 
@@ -683,8 +676,7 @@ function FluxCalculator.compute_surface_fluxes!(
     surface_params = LP.surface_fluxes_parameters(sim.model.soil.parameters.earth_param_set)
     @. csf.scalar_temp1 =
         -csf.ustar^3 / SFP.von_karman_const(surface_params) / non_zero(csf.buoyancy_flux)
-    @. csf.scalar_temp1 =
-        ifelse(area_fraction == 0, zero(csf.scalar_temp1), csf.scalar_temp1)
+    @. csf.scalar_temp1 = ifelse(area_fraction == 0, 0, csf.scalar_temp1)
     # When L_MO is infinite, avoid multiplication by zero to prevent NaN
     @. csf.L_MO +=
         ifelse(isinf(csf.scalar_temp1), csf.scalar_temp1, csf.scalar_temp1 * area_fraction)

experiments/ClimaEarth/components/ocean/prescr_seaice.jl

@@ -337,7 +337,7 @@ function ice_rhs!(dY, Y, p, t)
         F_conductive
     ) / (h * ρ * c)
     # Zero out tendencies where there is no ice, so that ice temperature remains constant there
-    @. rhs = ifelse(p.area_fraction ≈ 0, zero(rhs), rhs)
+    @. rhs = ifelse(p.area_fraction ≈ 0, 0, rhs)
 
     # If tendencies lead to temperature above freezing, set temperature to freezing
     @. dY.T_bulk = min(rhs, (T_freeze - Y.T_bulk) / float(p.dt))

experiments/ClimaEarth/components/ocean/slab_ocean.jl

@@ -262,7 +262,7 @@ function slab_ocean_rhs!(dY, Y, cache, t)
     rhs = @. (-F_turb_energy + (1 - α) * SW_d + ϵ * (LW_d - σ * Y.T_sfc^4)) / (h * ρ * c)
 
     # Zero out tendencies where there is no ocean, so that temperature remains constant there
-    @. rhs = ifelse(cache.area_fraction ≈ 0, zero(rhs), rhs)
+    @. rhs = ifelse(cache.area_fraction ≈ 0, 0, rhs)
 
     # Note that the area fraction has already been applied to the fluxes,
     #  so we don't need to multiply by it here.

experiments/ClimaEarth/test/fluxes_test.jl

@@ -46,10 +46,10 @@ include(joinpath("..", "setup_run.jl"))
     p = land_sim.integrator.p
     land_fraction = Interfacer.get_field(land_sim, Val(:area_fraction))
     land_flux = Interfacer.remap(land_sim.integrator.p.bucket.R_n, boundary_space)
-    @. land_flux = ifelse(land_fraction ≈ 0, zero(land_flux), land_flux)
+    @. land_flux = ifelse(land_fraction ≈ 0, 0, land_flux)
 
     err_land = @. atmos_flux - land_flux
-    @. err_land = ifelse(land_fraction ≈ 0, zero(err_land), err_land)
+    @. err_land = ifelse(land_fraction ≈ 0, 0, err_land)
     @show "Bucket flux error: $(maximum(abs.(err_land)))"
     @test maximum(abs.(err_land)) < 5
 
@@ -65,7 +65,7 @@ include(joinpath("..", "setup_run.jl"))
     ice_rad_flux =
         (1 .- α) .* p.SW_d .+
         ϵ .* (p.LW_d .- σ .* Interfacer.get_field(ice_sim, Val(:surface_temperature)) .^ 4)
-    @. ice_rad_flux = ifelse(p.area_fraction ≈ 0, zero(ice_rad_flux), ice_rad_flux)
+    @. ice_rad_flux = ifelse(p.area_fraction ≈ 0, 0, ice_rad_flux)
     ice_fraction = Interfacer.get_field(ice_sim, Val(:area_fraction))
 
     # Prescribed ocean: SST is prescribed, but for this test we can still compute

src/FieldExchanger.jl

@@ -342,7 +342,7 @@ function combine_surfaces!(combined_field, sims, field_name, scalar_temp)
                 scalar_temp .*
                 ifelse.(
                     scalar_temp .≈ 0,
-                    zero(combined_field),
+                    0,
                     Interfacer.get_field(sim, field_name, boundary_space),
                 )
         end
@@ -373,7 +373,7 @@ function combine_surfaces!(csf, sims, field_name::Val{:surface_temperature})
                 area_fraction .*
                 ifelse.(
                     area_fraction .≈ 0,
-                    zero(T_sfc),
+                    0,
                     emissivity_sim .*
                     Interfacer.get_field(sim, field_name, boundary_space) .^ FT(4),
                 )

src/FluxCalculator.jl

@@ -332,14 +332,14 @@ function compute_surface_fluxes!(
     # Zero out fluxes where the area fraction is zero
     # Multiplying by `area_fraction` is not sufficient because the fluxes may
     # be NaN where the area fraction is zero.
-    @. F_turb_ρτxz = ifelse(area_fraction ≈ 0, zero(F_turb_ρτxz), F_turb_ρτxz)
-    @. F_turb_ρτyz = ifelse(area_fraction ≈ 0, zero(F_turb_ρτyz), F_turb_ρτyz)
-    @. F_sh = ifelse(area_fraction ≈ 0, zero(F_sh), F_sh)
-    @. F_lh = ifelse(area_fraction ≈ 0, zero(F_lh), F_lh)
-    @. F_turb_moisture = ifelse(area_fraction ≈ 0, zero(F_turb_moisture), F_turb_moisture)
-    @. L_MO = ifelse(area_fraction ≈ 0, zero(L_MO), L_MO)
-    @. ustar = ifelse(area_fraction ≈ 0, zero(ustar), ustar)
-    @. buoyancy_flux = ifelse(area_fraction ≈ 0, zero(buoyancy_flux), buoyancy_flux)
+    @. F_turb_ρτxz = ifelse(area_fraction ≈ 0, 0, F_turb_ρτxz)
+    @. F_turb_ρτyz = ifelse(area_fraction ≈ 0, 0, F_turb_ρτyz)
+    @. F_sh = ifelse(area_fraction ≈ 0, 0, F_sh)
+    @. F_lh = ifelse(area_fraction ≈ 0, 0, F_lh)
+    @. F_turb_moisture = ifelse(area_fraction ≈ 0, 0, F_turb_moisture)
+    @. L_MO = ifelse(area_fraction ≈ 0, 0, L_MO)
+    @. ustar = ifelse(area_fraction ≈ 0, 0, ustar)
+    @. buoyancy_flux = ifelse(area_fraction ≈ 0, 0, buoyancy_flux)
 
     # update the fluxes, which are now area-weighted, of this surface model
     fields = (; F_turb_ρτxz, F_turb_ρτyz, F_lh, F_sh, F_turb_moisture)