Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 1 | Bug Report: Stope hashtag loop#112
Open
Nataliia74 wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Conversation
Nataliia74
added
the
Needs Review
jenny-alexander
added
Review in progress
jenny-alexander
left a comment
jenny-alexander
left a comment
There was a problem hiding this comment.
Your approach to solving this bug is very close to the solution we're looking for.
Have a look at apiService.getBloomsByHashtag. Notice a few things about the function:
- it sets
state.currentHashtag - it removes the hashtag character (#) if it's found at the beginning of the hashtag
Can you make modifications to your bug fix while taking into account the above into account?
Any formatting changes that are not related to the bug fix should be made in a separate commit. Can you make this change?
jenny-alexander
added
Reviewed
Nataliia74
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Prevented refetching the same hashtag, stopping the infinite-loop / slowdown..Made hashtags consistent, normalisation.