To introduce deserialize for ConfigureValidator type #625
+141
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soerenbf
reviewed
Dec 1, 2025
…om/Concordium/concordium-node-sdk-js into SPO-34/configure-baker-deserialize
soerenbf
approved these changes
Dec 2, 2025
Comment on lines
+326
to
+356
| const payload: ConfigureBakerPayload = { | ||
| stake: CcdAmount.fromMicroCcd(1000), | ||
|
|
||
| restakeEarnings: true, | ||
|
|
||
| openForDelegation: OpenStatus.OpenForAll, | ||
|
|
||
| keys: { | ||
| electionVerifyKey: 'aa'.repeat(32), | ||
|
|
||
| proofElection: 'bb'.repeat(64), | ||
|
|
||
| signatureVerifyKey: 'cc'.repeat(32), | ||
|
|
||
| proofSig: 'dd'.repeat(64), | ||
|
|
||
| aggregationVerifyKey: 'ee'.repeat(96), | ||
|
|
||
| proofAggregation: 'ff'.repeat(64), | ||
| }, | ||
|
|
||
| metadataUrl: 'g'.repeat(16), | ||
|
|
||
| transactionFeeCommission: 10, | ||
|
|
||
| bakingRewardCommission: 5, | ||
|
|
||
| finalizationRewardCommission: 2, | ||
|
|
||
| suspended: true, | ||
| }; |
Collaborator
There was a problem hiding this comment.
Could we limit the amount of blank lines? 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To introduce support for ConfigureValidator (aka ConfigureBaker) deserialize function as part of ensuring serialize and deserialize are available for all account transactions which are currently supported.
Changes
implement deserialize function in ConfigureBakerHandler
Checklist
hard-to-understand areas.
CLA acceptance
_Remove if not applicable.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.