concore.hpp initval() segfaults on empty input

[avinxshKD]

initval() does simtime = val[0] right after parsing without checking if val is empty. Pass it "[]" or garbage string and it's instant UB/segfault.

vector<double> val = parser(f);
simtime = val[0];          // boom
val.erase(val.begin());    // double boom

read_FM and read_SM in the same file already do if(inval.empty()) return inval; so someone knew about this. initval just got skipped.

concoredocker.hpp handles it fine (if (!val.empty())). Python side too. Only concore.hpp is broken.

not hard to fix, just add the empty check before accessing [0]. but its a crash in core library code so kinda important

[avinxshKD]

Hey @pradeeban this would be a good fix, let me know if it makes sense, thanks

[pradeeban]

ok, go ahead.

[avinxshKD]

@pradeeban verified on latest dev most of fix is already covered by #438 (initval() now guards empty parsed input before indexing)
Any additional tweak here would be behavior-neutral, so I’m closing as resolved