fix(device/base): remove stop, use shutdown!

Author: stakach

examples/matter_bridge_device.cr

@@ -597,7 +597,7 @@ module MatterBridge
       return unless confirmation && confirmation.strip.downcase == "yes"
 
       puts "Performing factory reset..."
-      stop
+      shutdown!
       File.delete(STORAGE_FILE) if File.exists?(STORAGE_FILE)
       puts "Factory reset complete"
       puts "Please restart the application"

examples/matter_level_control_device.cr

@@ -344,7 +344,7 @@ module MatterLevelControl
       return unless confirmation && confirmation.strip.downcase == "yes"
 
       puts "Performing factory reset..."
-      stop
+      shutdown!
       File.delete(STORAGE_FILE) if File.exists?(STORAGE_FILE)
       puts "Factory reset complete."
       puts "Please restart the application."

examples/matter_switch_device.cr

@@ -290,7 +290,7 @@ module MatterSwitch
       return unless confirmation && confirmation.strip.downcase == "yes"
 
       puts "🔄 Performing factory reset..."
-      stop
+      shutdown!
       File.delete(STORAGE_FILE) if File.exists?(STORAGE_FILE)
       puts "✅ Factory reset complete"
       puts "🔄 Please restart the application"

src/matter/device/base.cr

@@ -153,15 +153,6 @@ module Matter
       # Signals shutdown, stops all services, and unblocks all `await_shutdown` waiters.
       # Safe to call from signal handlers or other fibers.
       def shutdown! : Nil
-        stop
-        on_shutdown
-      rescue error
-        Log.error(exception: error) { "error performing shutdown" }
-      ensure
-        @shutdown_channel.close
-      end
-
-      def stop : Nil
         # Persist all session state before shutdown to ensure message counters
         # and other session data are saved for clean reconnection after restart
         @message_handler.persist_all_sessions
@@ -172,6 +163,11 @@ module Matter
         @storage_manager.stop
         @transport.close
         @responder.stop
+        on_shutdown
+      rescue error
+        Log.error(exception: error) { "error performing shutdown" }
+      ensure
+        @shutdown_channel.close
       end
 
       # ------------------------------------------------------------------------