Skip to content

Clean up plotting.spatial_overview #647

@ecomodeller

Description

@ecomodeller

src/modelskill/plotting/_spatial_overview.py has accumulated debt over time. Worth a focused cleanup pass.

Symptoms

Suggested direction

  • Make the accept list explicit: which model/geometry types does this function plot, and what does it do for each?
  • Decide on GridModelResult support (or document the gap) — the TODO has been there for a while
  • Consider whether 3D-aware behavior belongs here or in a model.outline helper on the model classes themselves (each type knows how to draw its own footprint)
  • Type hints should match the accepted set, not the duck-typed reality

Out of scope for the fix PR

This issue is the place to design the cleanup; the immediate notebook-test breakage is fixed in #646.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions