Skip to content

Conversation

@alexandrevryghem
Copy link
Member

Description

Fixed COAR Notify not rendering any logs & aligned the styling of the LDN service form with the other submission forms.

image image

Instructions for Reviewers

List of changes in this PR:

  • Fixed COAR Notify not displaying any inbound/outbound logs
  • Restyled the LDN service page to use the same layout classes & styles as the other DSpace forms
  • Fixed error being thrown in AbstractComponentLoader when no match is found

Guidance for how to test or review this PR:

  • Set up COAR Notify between demo.dspace.org and sandbox.dspace.org (I’ve already configured it, but these are the docs that explain how to configure it)
  • Verify that the submission form still works as before
  • Verify that when you start your local Angular instance against the sandbox/demo server, you can now see inbound/outbound logs. These logs are automatically created when you submit new items, so if the list is empty, submit an item and you should see a new log shortly

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem added this to the 10.0 milestone Nov 24, 2025
@alexandrevryghem alexandrevryghem self-assigned this Nov 24, 2025
@alexandrevryghem alexandrevryghem added bug ux User Experience related works integration: COAR Notify / LDN Related to Linked Data Notifications (LDN) or COAR Notify services labels Nov 24, 2025
@alexandrevryghem alexandrevryghem moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug integration: COAR Notify / LDN Related to Linked Data Notifications (LDN) or COAR Notify services ux User Experience related works

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

1 participant