Add proper rewards to some goals.

Author: MikuAuahDark

npps4/server_data.json

@@ -3057,6 +3057,15 @@
 				}
 			]
 		},
+		{
+			"achievement_id": 503,
+			"rewards": [
+				{
+					"add_type": 5000,
+					"item_id": 495
+				}
+			]
+		},
 		{
 			"achievement_id": 504,
 			"rewards": [
@@ -3075,6 +3084,15 @@
 				}
 			]
 		},
+		{
+			"achievement_id": 508,
+			"rewards": [
+				{
+					"add_type": 5000,
+					"item_id": 496
+				}
+			]
+		},
 		{
 			"achievement_id": 509,
 			"rewards": [
@@ -3120,6 +3138,15 @@
 				}
 			]
 		},
+		{
+			"achievement_id": 518,
+			"rewards": [
+				{
+					"add_type": 5000,
+					"item_id": 498
+				}
+			]
+		},
 		{
 			"achievement_id": 519,
 			"rewards": [
@@ -3165,6 +3192,15 @@
 				}
 			]
 		},
+		{
+			"achievement_id": 528,
+			"rewards": [
+				{
+					"add_type": 5000,
+					"item_id": 494
+				}
+			]
+		},
 		{
 			"achievement_id": 529,
 			"rewards": [
@@ -3210,6 +3246,15 @@
 				}
 			]
 		},
+		{
+			"achievement_id": 538,
+			"rewards": [
+				{
+					"add_type": 5000,
+					"item_id": 502
+				}
+			]
+		},
 		{
 			"achievement_id": 539,
 			"rewards": [
@@ -3255,6 +3300,15 @@
 				}
 			]
 		},
+		{
+			"achievement_id": 548,
+			"rewards": [
+				{
+					"add_type": 5000,
+					"item_id": 501
+				}
+			]
+		},
 		{
 			"achievement_id": 549,
 			"rewards": [
@@ -3300,6 +3354,15 @@
 				}
 			]
 		},
+		{
+			"achievement_id": 558,
+			"rewards": [
+				{
+					"add_type": 5000,
+					"item_id": 505
+				}
+			]
+		},
 		{
 			"achievement_id": 559,
 			"rewards": [
@@ -3345,6 +3408,15 @@
 				}
 			]
 		},
+		{
+			"achievement_id": 568,
+			"rewards": [
+				{
+					"add_type": 5000,
+					"item_id": 506
+				}
+			]
+		},
 		{
 			"achievement_id": 569,
 			"rewards": [
@@ -3390,6 +3462,15 @@
 				}
 			]
 		},
+		{
+			"achievement_id": 578,
+			"rewards": [
+				{
+					"add_type": 5000,
+					"item_id": 511
+				}
+			]
+		},
 		{
 			"achievement_id": 579,
 			"rewards": [

scripts/migrations/8_achievement_fix_1.py

@@ -0,0 +1,35 @@
+import npps4.script_dummy  # isort:skip
+
+import sqlalchemy
+
+import npps4.idol
+import npps4.db.main
+import npps4.system.achievement
+import npps4.system.advanced
+import npps4.system.user
+
+revision = "8_achievement_fix_1"
+prev_revision = "7_give_loveca_to_cleared_songs"
+
+FIXES_ACHIEVEMENT_IDS = [503, *range(508, 588, 10)]
+
+
+async def main(context: npps4.idol.BasicSchoolIdolContext):
+    q = sqlalchemy.select(npps4.db.main.Achievement).where(
+        npps4.db.main.Achievement.achievement_id.in_(FIXES_ACHIEVEMENT_IDS),
+        npps4.db.main.Achievement.is_accomplished == True,
+        npps4.db.main.Achievement.is_reward_claimed == True,
+    )
+
+    async for ach in (await context.db.main.stream(q)).scalars():
+        user = await npps4.system.user.get(context, ach.user_id)
+        if user is None:
+            continue
+
+        rewards = await npps4.system.achievement.get_achievement_rewards(context, ach)
+        for reward in rewards:
+            result = await npps4.system.advanced.add_item(context, user, reward)
+            print(
+                f"Give reward ({reward.add_type.value, reward.item_id})x{reward.amount} to user {user.id} by ach {ach.achievement_id}",
+                "successful" if result.success else "unsuccessful",
+            )