test(profiling): revert temporarily mark flaky tests as xfail (#15439)

## Description

https://datadoghq.atlassian.net/browse/PROF-13152

This reverts commit 4753e14 (from
#15433) and unmarks new
Profiling tests as `xfail`.

Why is it OK to do that?
* We actually only had two flaky tests, one that was from Echion
(`test_asyncio_coroutines.py`) and one (or some) that were previously
added, e.g.
`test_asyncio_import_profiler_from_process_after_starting_loop`
* I fixed `test_asyncio_coroutines` by asserting not on a specific line,
but any line within the function we wanted to see. It's not perfect, but
the line detection is somewhat flaky for on-CPU Tasks (for the time
being, this will soon be fixed hopefully!)
* I fixed the `import_profiler...` tests by doing the same thing,
because the line we were getting Samples for was not consistent across
runs and in that case, we aren't really interested in the exact lines –
we just want to make sure that we're actually getting Samples even when
starting the Profiler later.

[Proof of no
flakes](https://app.datadoghq.com/ci/test/runs?query=test_level%3Atest%20%40git.branch%3Akowalski%2Ftest-profiling-revert-temporarily-mark-flaky-tests-as-xfail-15433%20%40test.service%3Add-trace-py%20%40test.status%3Afail%20%40git.commit.sha%3A33f587f128%2A&agg_m=count&agg_m_source=base&agg_t=count&currentTab=overview&eventStack=&fromUser=false&index=citest&start=1764235048278&end=1764238648278&paused=false)
on those tests on the latest version
(`test_uwsgi_threads_processes_no_primary_lazy_apps[py3.12]` is
unrelated).

Author: KowalskiThomas

tests/profiling/collector/pprof_utils.py

@@ -358,6 +358,7 @@ def assert_profile_has_sample(
     profile: pprof_pb2.Profile,
     samples: List[pprof_pb2.Sample],
     expected_sample: StackEvent,
+    print_samples_on_failure: bool = False,
 ) -> None:
     found = False
     for sample in samples:
@@ -370,6 +371,9 @@ def assert_profile_has_sample(
             if DEBUG_TEST:
                 print(e)
 
+    if not found and print_samples_on_failure:
+        print_all_samples(profile)
+
     assert found, "Expected samples not found in profile " + str(expected_sample.locations)
 
 

tests/profiling/collector/test_asyncio_context_manager.py

@@ -1,7 +1,11 @@
+from sys import version_info as PYVERSION
+
 import pytest
 
 
-@pytest.mark.xfail(reason="Temporarily marking new tests as xfail until we make them non-flaky")
+@pytest.mark.xfail(
+    condition=PYVERSION >= (3, 13), reason="Sampling async context manager stacks does not work on >=3.13"
+)
 @pytest.mark.subprocess(
     env=dict(
         DD_PROFILING_OUTPUT_PPROF="/tmp/test_asyncio_context_manager",

tests/profiling/collector/test_asyncio_coroutines.py

@@ -1,7 +1,6 @@
 import pytest
 
 
-@pytest.mark.xfail(reason="Temporarily marking new tests as xfail until we make them non-flaky")
 @pytest.mark.subprocess(
     env=dict(
         DD_PROFILING_OUTPUT_PPROF="/tmp/test_asyncio_coroutines",
@@ -100,6 +99,7 @@ async def outer_function() -> None:
                 ),
             ],
         ),
+        print_samples_on_failure=True,
     )
 
     # Test that we see the background_task_func task
@@ -126,6 +126,7 @@ async def outer_function() -> None:
                 ),
             ],
         ),
+        print_samples_on_failure=True,
     )
 
     # Test that we see the background_math_function task
@@ -138,7 +139,7 @@ async def outer_function() -> None:
                 pprof_utils.StackLocation(
                     function_name="background_math_function",
                     filename="test_asyncio_coroutines.py",
-                    line_no=background_math_function.__code__.co_firstlineno + 2,
+                    line_no=-1,  # any line
                 ),
                 # TODO: We should see outer_function, but for some reason we simply do not...
                 # pprof_utils.StackLocation(
@@ -148,4 +149,5 @@ async def outer_function() -> None:
                 # ),
             ],
         ),
+        print_samples_on_failure=True,
     )

tests/profiling/collector/test_asyncio_deadlock.py

@@ -1,7 +1,6 @@
 import pytest
 
 
-@pytest.mark.xfail(reason="Temporarily marking new tests as xfail until we make them non-flaky")
 @pytest.mark.subprocess(
     env=dict(
         DD_PROFILING_OUTPUT_PPROF="/tmp/test_asyncio_deadlock",

tests/profiling/collector/test_asyncio_executor.py

@@ -1,7 +1,6 @@
 import pytest
 
 
-@pytest.mark.xfail(reason="Temporarily marking new tests as xfail until we make them non-flaky")
 @pytest.mark.subprocess(
     env=dict(
         DD_PROFILING_OUTPUT_PPROF="/tmp/test_asyncio_executor",

tests/profiling/collector/test_asyncio_gather_coroutines.py

@@ -1,7 +1,6 @@
 import pytest
 
 
-@pytest.mark.xfail(reason="Temporarily marking new tests as xfail until we make them non-flaky")
 @pytest.mark.subprocess(
     env=dict(
         DD_PROFILING_OUTPUT_PPROF="/tmp/test_asyncio_gather_coroutines",

tests/profiling/collector/test_asyncio_gather_tasks.py

@@ -1,7 +1,6 @@
 import pytest
 
 
-@pytest.mark.xfail(reason="Temporarily marking new tests as xfail until we make them non-flaky")
 @pytest.mark.subprocess(
     env=dict(
         DD_PROFILING_OUTPUT_PPROF="/tmp/test_asyncio_gather_tasks",

tests/profiling/collector/test_asyncio_wait.py

@@ -1,7 +1,6 @@
 import pytest
 
 
-@pytest.mark.xfail(reason="Temporarily marking new tests as xfail until we make them non-flaky")
 @pytest.mark.subprocess(
     env=dict(
         DD_PROFILING_OUTPUT_PPROF="/tmp/test_asyncio_wait",

tests/profiling/collector/test_generators.py

@@ -1,7 +1,6 @@
 import pytest
 
 
-@pytest.mark.xfail(reason="Temporarily marking new tests as xfail until we make them non-flaky")
 @pytest.mark.subprocess(
     env=dict(
         DD_PROFILING_OUTPUT_PPROF="/tmp/test_generators",