-
Notifications
You must be signed in to change notification settings - Fork 468
feat(aap): add redirect request support for api10 on urllib #15443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(aap): add redirect request support for api10 on urllib #15443
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 246 ± 3 ms. The average import time from base is: 247 ± 2 ms. The import time difference between this PR and base is: -1.1 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate christophe-papazian/api10_redirection_urllib (11e085e) with baseline main (84e0f46) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.973µs (SLO: <10.000µs 📉 -50.3%) vs baseline: 📈 +21.5% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.1% ✅ ospathbasename_noaspectTime: ✅ 1.074µs (SLO: <10.000µs 📉 -89.3%) vs baseline: -0.7% Memory: ✅ 40.403MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +5.5% ✅ ospathjoin_aspectTime: ✅ 6.082µs (SLO: <10.000µs 📉 -39.2%) vs baseline: -1.2% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.5% ✅ ospathjoin_noaspectTime: ✅ 2.284µs (SLO: <10.000µs 📉 -77.2%) vs baseline: ~same Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.438µs (SLO: <10.000µs 📉 -65.6%) vs baseline: +0.8% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.6% ✅ ospathnormcase_noaspectTime: ✅ 0.565µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +0.2% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.7% ✅ ospathsplit_aspectTime: ✅ 4.677µs (SLO: <10.000µs 📉 -53.2%) vs baseline: -1.3% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 1.591µs (SLO: <10.000µs 📉 -84.1%) vs baseline: ~same Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.2% ✅ ospathsplitdrive_aspectTime: ✅ 3.639µs (SLO: <10.000µs 📉 -63.6%) vs baseline: +1.2% Memory: ✅ 40.423MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.695µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.1% Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.480µs (SLO: <10.000µs 📉 -55.2%) vs baseline: -0.3% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.6% ✅ ospathsplitext_noaspectTime: ✅ 1.375µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -0.4% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.6% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.454µs (SLO: <20.000µs 📉 -82.7%) vs baseline: 📈 +17.7% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.5% ✅ 1-count-metrics-100-timesTime: ✅ 203.109µs (SLO: <220.000µs -7.7%) vs baseline: +1.2% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 1-distribution-metric-1-timesTime: ✅ 3.314µs (SLO: <20.000µs 📉 -83.4%) vs baseline: +0.5% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.953µs (SLO: <230.000µs -6.1%) vs baseline: +1.3% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.157µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -2.6% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.048µs (SLO: <150.000µs -9.3%) vs baseline: -0.6% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.105µs (SLO: <20.000µs 📉 -84.5%) vs baseline: +1.2% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 215.671µs (SLO: <250.000µs 📉 -13.7%) vs baseline: +0.9% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.2% ✅ 100-count-metrics-100-timesTime: ✅ 20.334ms (SLO: <22.000ms -7.6%) vs baseline: +1.1% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +5.1% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.244ms (SLO: <2.300ms -2.4%) vs baseline: +0.6% Memory: ✅ 35.154MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.5% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.404ms (SLO: <1.550ms -9.4%) vs baseline: -0.1% Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.210ms (SLO: <2.550ms 📉 -13.3%) vs baseline: +0.2% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +5.2% ✅ flush-1-metricTime: ✅ 4.491µs (SLO: <20.000µs 📉 -77.5%) vs baseline: +1.0% Memory: ✅ 35.252MB (SLO: <35.500MB 🟡 -0.7%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 173.944µs (SLO: <250.000µs 📉 -30.4%) vs baseline: -0.8% Memory: ✅ 35.311MB (SLO: <35.500MB 🟡 -0.5%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.185ms (SLO: <2.500ms 📉 -12.6%) vs baseline: +0.5% Memory: ✅ 36.078MB (SLO: <36.500MB 🟡 -1.2%) vs baseline: +5.0% 🟡 Near SLO Breach (18 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
…pi10_redirection_urllib
…pi10_redirection_urllib
…pi10_redirection_urllib
Description
Testing
Risks
Additional Notes