-
Notifications
You must be signed in to change notification settings - Fork 469
chore(ci_visibility): add telemetry to the new plugin, part 1 #15449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…raujo/SDTEST-2803/reabsorb-ddtestpy
…raujo/SDTEST-2803/reabsorb-ddtestpy
…raujo/SDTEST-2803/reabsorb-ddtestpy
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 218 ± 3 ms. The average import time from base is: 220 ± 5 ms. The import time difference between this PR and base is: -1.7 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate vitor-de-araujo/SDTEST-2663/telemetry (8b82b3f) with baseline main (20e2087) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +1.4% Memory: ✅ 40.181MB (SLO: <41.500MB -3.2%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.4% Memory: ✅ 40.356MB (SLO: <41.500MB -2.8%) vs baseline: +5.0% ✅ add_inplace_noaspectTime: ✅ 0.319µs (SLO: <10.000µs 📉 -96.8%) vs baseline: ~same Memory: ✅ 40.266MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ add_noaspectTime: ✅ 0.280µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.3% Memory: ✅ 40.186MB (SLO: <41.500MB -3.2%) vs baseline: +4.9% ✅ bytearray_aspectTime: ✅ 1.349µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +0.4% Memory: ✅ 40.143MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ bytearray_extend_aspectTime: ✅ 1.504µs (SLO: <10.000µs 📉 -85.0%) vs baseline: -0.7% Memory: ✅ 40.099MB (SLO: <41.500MB -3.4%) vs baseline: +4.5% ✅ bytearray_extend_noaspectTime: ✅ 0.613µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.3% Memory: ✅ 40.069MB (SLO: <41.500MB -3.4%) vs baseline: +4.1% ✅ bytearray_noaspectTime: ✅ 0.483µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.4% Memory: ✅ 40.064MB (SLO: <41.500MB -3.5%) vs baseline: +4.7% ✅ bytes_aspectTime: ✅ 1.295µs (SLO: <10.000µs 📉 -87.1%) vs baseline: +0.7% Memory: ✅ 40.141MB (SLO: <41.500MB -3.3%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +2.1% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 1.363µs (SLO: <10.000µs 📉 -86.4%) vs baseline: +3.6% Memory: ✅ 40.143MB (SLO: <41.500MB -3.3%) vs baseline: +4.5% ✅ bytesio_noaspectTime: ✅ 0.507µs (SLO: <10.000µs 📉 -94.9%) vs baseline: +1.0% Memory: ✅ 40.263MB (SLO: <41.500MB -3.0%) vs baseline: +5.2% ✅ capitalize_aspectTime: ✅ 0.734µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.5% Memory: ✅ 40.161MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ capitalize_noaspectTime: ✅ 0.441µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +2.0% Memory: ✅ 40.106MB (SLO: <41.500MB -3.4%) vs baseline: +4.6% ✅ casefold_aspectTime: ✅ 0.741µs (SLO: <10.000µs 📉 -92.6%) vs baseline: ~same Memory: ✅ 40.263MB (SLO: <41.500MB -3.0%) vs baseline: +5.1% ✅ casefold_noaspectTime: ✅ 0.372µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.4% Memory: ✅ 40.140MB (SLO: <41.500MB -3.3%) vs baseline: +5.0% ✅ decode_aspectTime: ✅ 0.729µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.8% Memory: ✅ 40.287MB (SLO: <41.500MB -2.9%) vs baseline: +5.2% ✅ decode_noaspectTime: ✅ 0.414µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.7% Memory: ✅ 40.223MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ encode_aspectTime: ✅ 0.710µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.3% Memory: ✅ 40.139MB (SLO: <41.500MB -3.3%) vs baseline: +4.7% ✅ encode_noaspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.1% Memory: ✅ 40.240MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 3.411µs (SLO: <10.000µs 📉 -65.9%) vs baseline: -1.1% Memory: ✅ 40.224MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 3.511µs (SLO: <10.000µs 📉 -64.9%) vs baseline: -2.3% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ format_map_noaspectTime: ✅ 0.776µs (SLO: <10.000µs 📉 -92.2%) vs baseline: -0.3% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +5.1% ✅ format_noaspectTime: ✅ 0.599µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.3% Memory: ✅ 40.181MB (SLO: <41.500MB -3.2%) vs baseline: +5.2% ✅ index_aspectTime: ✅ 0.358µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -0.8% Memory: ✅ 40.142MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ index_noaspectTime: ✅ 0.287µs (SLO: <10.000µs 📉 -97.1%) vs baseline: +3.8% Memory: ✅ 40.243MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 1.340µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +0.9% Memory: ✅ 40.141MB (SLO: <41.500MB -3.3%) vs baseline: +4.8% ✅ join_noaspectTime: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.6% Memory: ✅ 40.084MB (SLO: <41.500MB -3.4%) vs baseline: +4.8% ✅ ljust_aspectTime: ✅ 2.576µs (SLO: <20.000µs 📉 -87.1%) vs baseline: +0.6% Memory: ✅ 40.166MB (SLO: <41.500MB -3.2%) vs baseline: +4.3% ✅ ljust_noaspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.6% Memory: ✅ 40.244MB (SLO: <41.500MB -3.0%) vs baseline: +5.3% ✅ lower_aspectTime: ✅ 2.304µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +2.9% Memory: ✅ 40.347MB (SLO: <41.500MB -2.8%) vs baseline: +4.8% ✅ lower_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.4% Memory: ✅ 40.244MB (SLO: <41.500MB -3.0%) vs baseline: +4.4% ✅ lstrip_aspectTime: ✅ 2.267µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +1.3% Memory: ✅ 40.302MB (SLO: <41.500MB -2.9%) vs baseline: +4.8% ✅ lstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.4% Memory: ✅ 40.362MB (SLO: <41.500MB -2.7%) vs baseline: +5.3% ✅ modulo_aspectTime: ✅ 1.051µs (SLO: <10.000µs 📉 -89.5%) vs baseline: +4.3% Memory: ✅ 40.078MB (SLO: <41.500MB -3.4%) vs baseline: +4.7% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.548µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -0.6% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.5% ✅ modulo_aspect_for_bytesTime: ✅ 0.980µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -0.1% Memory: ✅ 40.300MB (SLO: <41.500MB -2.9%) vs baseline: +4.8% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.260µs (SLO: <10.000µs 📉 -87.4%) vs baseline: +2.4% Memory: ✅ 40.372MB (SLO: <41.500MB -2.7%) vs baseline: +5.2% ✅ modulo_noaspectTime: ✅ 0.629µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.2% Memory: ✅ 40.061MB (SLO: <41.500MB -3.5%) vs baseline: +4.6% ✅ replace_aspectTime: ✅ 4.859µs (SLO: <10.000µs 📉 -51.4%) vs baseline: -1.4% Memory: ✅ 40.347MB (SLO: <41.500MB -2.8%) vs baseline: +5.0% ✅ replace_noaspectTime: ✅ 0.464µs (SLO: <10.000µs 📉 -95.4%) vs baseline: ~same Memory: ✅ 40.243MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ repr_aspectTime: ✅ 0.904µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -0.2% Memory: ✅ 40.122MB (SLO: <41.500MB -3.3%) vs baseline: +4.7% ✅ repr_noaspectTime: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.8% Memory: ✅ 40.227MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ rstrip_aspectTime: ✅ 1.969µs (SLO: <20.000µs 📉 -90.2%) vs baseline: +1.5% Memory: ✅ 40.062MB (SLO: <41.500MB -3.5%) vs baseline: +4.3% ✅ rstrip_noaspectTime: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.4% Memory: ✅ 40.225MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.9% Memory: ✅ 40.322MB (SLO: <41.500MB -2.8%) vs baseline: +5.5% ✅ slice_noaspectTime: ✅ 0.445µs (SLO: <10.000µs 📉 -95.6%) vs baseline: -1.3% Memory: ✅ 40.121MB (SLO: <41.500MB -3.3%) vs baseline: +4.8% ✅ stringio_aspectTime: ✅ 1.553µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +1.2% Memory: ✅ 40.142MB (SLO: <41.500MB -3.3%) vs baseline: +4.5% ✅ stringio_noaspectTime: ✅ 0.719µs (SLO: <10.000µs 📉 -92.8%) vs baseline: ~same Memory: ✅ 40.225MB (SLO: <41.500MB -3.1%) vs baseline: +5.4% ✅ strip_aspectTime: ✅ 2.255µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +0.5% Memory: ✅ 40.165MB (SLO: <41.500MB -3.2%) vs baseline: +4.6% ✅ strip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.9% Memory: ✅ 40.244MB (SLO: <41.500MB -3.0%) vs baseline: +5.2% ✅ swapcase_aspectTime: ✅ 2.766µs (SLO: <10.000µs 📉 -72.3%) vs baseline: 📈 +12.9% Memory: ✅ 40.126MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ swapcase_noaspectTime: ✅ 0.535µs (SLO: <10.000µs 📉 -94.6%) vs baseline: -0.8% Memory: ✅ 40.103MB (SLO: <41.500MB -3.4%) vs baseline: +4.6% ✅ title_aspectTime: ✅ 2.433µs (SLO: <10.000µs 📉 -75.7%) vs baseline: +2.0% Memory: ✅ 40.166MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ title_noaspectTime: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.5% Memory: ✅ 40.042MB (SLO: <41.500MB -3.5%) vs baseline: +4.4% ✅ translate_aspectTime: ✅ 3.330µs (SLO: <10.000µs 📉 -66.7%) vs baseline: +0.5% Memory: ✅ 40.099MB (SLO: <41.500MB -3.4%) vs baseline: +4.4% ✅ translate_noaspectTime: ✅ 1.041µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.1% Memory: ✅ 40.266MB (SLO: <41.500MB -3.0%) vs baseline: +5.2% ✅ upper_aspectTime: ✅ 2.307µs (SLO: <10.000µs 📉 -76.9%) vs baseline: +3.0% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.5% ✅ upper_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.9% Memory: ✅ 40.019MB (SLO: <41.500MB -3.6%) vs baseline: +4.5% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.151µs (SLO: <10.000µs 📉 -48.5%) vs baseline: 📈 +25.6% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 1.079µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -1.0% Memory: ✅ 40.088MB (SLO: <41.000MB -2.2%) vs baseline: +4.2% ✅ ospathjoin_aspectTime: ✅ 6.186µs (SLO: <10.000µs 📉 -38.1%) vs baseline: +0.5% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.6% ✅ ospathjoin_noaspectTime: ✅ 2.271µs (SLO: <10.000µs 📉 -77.3%) vs baseline: -0.5% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.3% ✅ ospathnormcase_aspectTime: ✅ 3.417µs (SLO: <10.000µs 📉 -65.8%) vs baseline: -0.2% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.8% ✅ ospathnormcase_noaspectTime: ✅ 0.564µs (SLO: <10.000µs 📉 -94.4%) vs baseline: -1.7% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.1% ✅ ospathsplit_aspectTime: ✅ 4.728µs (SLO: <10.000µs 📉 -52.7%) vs baseline: -0.5% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 1.588µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.3% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.620µs (SLO: <10.000µs 📉 -63.8%) vs baseline: -0.8% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.1% ✅ ospathsplitdrive_noaspectTime: ✅ 0.689µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -1.0% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.5% ✅ ospathsplitext_aspectTime: ✅ 4.482µs (SLO: <10.000µs 📉 -55.2%) vs baseline: -0.8% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 1.370µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -1.1% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.3% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.404µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +16.5% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.2% ✅ 1-count-metrics-100-timesTime: ✅ 202.831µs (SLO: <220.000µs -7.8%) vs baseline: +0.7% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.291µs (SLO: <20.000µs 📉 -83.5%) vs baseline: +0.1% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.8% ✅ 1-distribution-metrics-100-timesTime: ✅ 218.230µs (SLO: <230.000µs -5.1%) vs baseline: +0.9% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +5.1% ✅ 1-gauge-metric-1-timesTime: ✅ 2.176µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.2% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.2% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.140µs (SLO: <150.000µs -8.6%) vs baseline: +1.0% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.077µs (SLO: <20.000µs 📉 -84.6%) vs baseline: +0.4% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.8% ✅ 1-rate-metrics-100-timesTime: ✅ 216.314µs (SLO: <250.000µs 📉 -13.5%) vs baseline: +1.8% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.273ms (SLO: <22.000ms -7.8%) vs baseline: -0.5% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.291ms (SLO: <2.300ms 🟡 -0.4%) vs baseline: -1.0% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +5.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.413ms (SLO: <1.550ms -8.8%) vs baseline: +1.1% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.3% ✅ 100-rate-metrics-100-timesTime: ✅ 2.224ms (SLO: <2.550ms 📉 -12.8%) vs baseline: +0.5% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.563µs (SLO: <20.000µs 📉 -77.2%) vs baseline: ~same Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 173.558µs (SLO: <250.000µs 📉 -30.6%) vs baseline: -0.5% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.188ms (SLO: <2.500ms 📉 -12.5%) vs baseline: +0.1% Memory: ✅ 35.960MB (SLO: <36.500MB 🟡 -1.5%) vs baseline: +5.0% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
…raujo/SDTEST-2663/telemetry
Description
This PR:
http.clientmodule instead. Now theBackendConnectorrequest methods return aBackendResult, containing information about the response and any errors that may have happened, even if there is no response.telemetry_writerfromddtrace.internal.telemetry.Telemetry for things besides HTTP requests will be added separately.
Testing
Unit tests.
Risks
None.
Additional Notes
None.