Fix is:owned filter implementation following code review feedback

Co-authored-by: bhollis <[email protected]>

Author: Copilot

src/app/search/items/item-filter-types.ts

@@ -3,7 +3,6 @@ import { D2ManifestDefinitions } from 'app/destiny2/d2-definitions';
 import { DimLanguage } from 'app/i18n';
 import { TagValue } from 'app/inventory/dim-item-info';
 import { DimItem } from 'app/inventory/item-types';
-import { OwnedItemsInfo } from 'app/inventory/selectors';
 import { DimStore } from 'app/inventory/store-types';
 import { Loadout } from 'app/loadout/loadout-types';
 import { LoadoutsByItem } from 'app/loadout/selectors';
@@ -32,7 +31,6 @@ export interface FilterContext {
   language: DimLanguage;
   customStats: Settings['customStats'];
   d2Definitions: D2ManifestDefinitions | undefined;
-  ownedItemsInfo: OwnedItemsInfo;
 }
 
 /**

src/app/search/items/item-search-filter.ts

@@ -13,7 +13,6 @@ import {
   getNotesSelector,
   getTagSelector,
   newItemsSelector,
-  ownedItemsSelector,
   sortedStoresSelector,
 } from 'app/inventory/selectors';
 import { DimStore } from 'app/inventory/store-types';
@@ -141,7 +140,6 @@ const filterContextSelector = createSelector(
   languageSelector,
   customStatsSelector,
   d2ManifestSelector,
-  ownedItemsSelector,
   makeFilterContext,
 );
 
@@ -158,7 +156,6 @@ function makeFilterContext(
   language: DimLanguage,
   customStats: Settings['customStats'],
   d2Definitions: D2ManifestDefinitions | undefined,
-  ownedItemsInfo: import('app/inventory/selectors').OwnedItemsInfo,
 ): FilterContext {
   return {
     stores,
@@ -173,7 +170,6 @@ function makeFilterContext(
     customStats,
     wishListsByHash,
     d2Definitions,
-    ownedItemsInfo,
   };
 }
 

src/app/search/items/search-filters/simple.ts

@@ -97,18 +97,33 @@ const simpleFilters: ItemFilterDefinition[] = [
   },
   {
     keywords: 'owned',
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-    description: 'Filter.Owned' as any,
+    description: tl('Filter.Owned'),
     filter:
-      ({ ownedItemsInfo, currentStore }) =>
+      ({ allItems, currentStore }) =>
       (item) => {
+        // Build ownership info from allItems, similar to ownedItemsSelector
+        const storeSpecificBuckets = [BucketHashes.Emblems, BucketHashes.Quests];
+        const accountWideOwned = new Set<number>();
+        const storeSpecificOwned: { [owner: string]: Set<number> } = {};
+        
+        for (const ownedItem of allItems) {
+          if (storeSpecificBuckets.includes(ownedItem.bucket.hash)) {
+            if (!storeSpecificOwned[ownedItem.owner]) {
+              storeSpecificOwned[ownedItem.owner] = new Set();
+            }
+            storeSpecificOwned[ownedItem.owner].add(ownedItem.hash);
+          } else {
+            accountWideOwned.add(ownedItem.hash);
+          }
+        }
+
         // Check if item is owned globally (account-wide)
-        if (ownedItemsInfo.accountWideOwned.has(item.hash)) {
+        if (accountWideOwned.has(item.hash)) {
           return true;
         }
         // Check if item is owned by the current store (for store-specific items like emblems/quests)
-        if (currentStore && ownedItemsInfo.storeSpecificOwned[currentStore.id]) {
-          return ownedItemsInfo.storeSpecificOwned[currentStore.id].has(item.hash);
+        if (currentStore && storeSpecificOwned[currentStore.id]) {
+          return storeSpecificOwned[currentStore.id].has(item.hash);
         }
         return false;
       },