address PR comments

Author: delphiactual

.github/actions/setup-pnpm/action.yml

@@ -7,11 +7,6 @@ inputs:
     required: false
     default: 'true'
 
-  frozen-lockfile:
-    description: 'Use frozen lockfile for install (default: true)'
-    required: false
-    default: 'true'
-
 runs:
   using: 'composite'
   steps:
@@ -27,9 +22,4 @@ runs:
     - name: Install dependencies
       if: inputs.install == 'true'
       shell: bash
-      run: |
-        if [ "${{ inputs.frozen-lockfile }}" == "true" ]; then
-          pnpm install --frozen-lockfile --prefer-offline
-        else
-          pnpm install --prefer-offline
-        fi
+      run: pnpm install --frozen-lockfile --prefer-offline

.github/workflows/auto-merge.yml

@@ -20,14 +20,6 @@ jobs:
           app-id: ${{ secrets.AUTOMERGE_APP_ID }}
           private-key: ${{ secrets.AUTOMERGE_PRIVATE_KEY }}
 
-      # Security: Checkout PR code to review before auto-merging
-      # This ensures we're working with the actual PR content
-      - name: Checkout PR
-        uses: actions/checkout@v6
-        with:
-          ref: ${{ github.event.pull_request.head.sha }}
-          fetch-depth: 1
-
       - name: Check Dependabot metadata
         if: github.actor == 'dependabot[bot]'
         id: metadata

.github/workflows/changelog-updater.yml

@@ -22,39 +22,18 @@ jobs:
         with:
           install: 'false'  # Don't need dependencies for this script
 
-      # Process commits and generate changelog with proper error handling
+      # Process commits and generate changelog
       - name: Update changelog from commits
-        id: changelog
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           GITHUB_REPOSITORY: ${{ github.repository }}
           COMMIT_SHAS: ${{ join(github.event.commits.*.id, ' ') }}
         run: |
           set -e
-
-          # Generate new changelog
-          if node build/update-changelog.js $COMMIT_SHAS > docs/CHANGELOG.md.new; then
-            # Only update if the script succeeded
-            mv docs/CHANGELOG.md.new docs/CHANGELOG.md
-            echo "updated=true" >> $GITHUB_OUTPUT
-          else
-            echo "::error::Failed to update changelog"
-            rm -f docs/CHANGELOG.md.new
-            echo "updated=false" >> $GITHUB_OUTPUT
-            exit 1
-          fi
-
-      - name: Check for actual changes
-        id: check-changes
-        run: |
-          if git diff --quiet docs/CHANGELOG.md; then
-            echo "changed=false" >> $GITHUB_OUTPUT
-          else
-            echo "changed=true" >> $GITHUB_OUTPUT
-          fi
+          node build/update-changelog.js $COMMIT_SHAS > docs/CHANGELOG.md.new
+          mv docs/CHANGELOG.md.new docs/CHANGELOG.md
 
       - name: Commit files
-        if: steps.check-changes.outputs.changed == 'true'
         uses: stefanzweifel/git-auto-commit-action@v7
         with:
           commit_message: Apply changelog updates

.github/workflows/i18n-bot-download.yml

@@ -34,29 +34,11 @@ jobs:
           CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-      # Sort all locale files with proper error handling
       - name: Sort locale JSON files
         run: |
-          set -e  # Exit immediately if a command fails
-
           allLocales=("en" "de" "es" "esMX" "fr" "it" "ja" "ko" "pl" "ptBR" "ru" "zhCHS" "zhCHT")
-
-          for lang in "${allLocales[@]}"; do
-            file="src/locale/$lang.json"
-            if [ -f "$file" ]; then
-              echo "Sorting $file..."
-              # Use atomic operations with temp file
-              if jq -S . "$file" > "$file.tmp"; then
-                mv "$file.tmp" "$file"
-                echo "✅ Sorted $file"
-              else
-                echo "::error::Failed to sort $file"
-                rm -f "$file.tmp"
-                exit 1
-              fi
-            else
-              echo "::warning::File $file not found, skipping"
-            fi
+          for lang in ${allLocales[@]}; do
+            jq -S . src/locale/$lang.json > src/locale/sorted_$lang.json && mv src/locale/sorted_$lang.json src/locale/$lang.json
           done
 
       - name: Build browsercheck utils

.github/workflows/i18n-bot-upload.yml

@@ -17,9 +17,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Sort en.json
-        run: |
-          sorted=$(jq -S . src/locale/en.json)
-          echo "$sorted" > src/locale/en.json
+        run: dimJSON="$(jq -S . src/locale/en.json)" && echo "${dimJSON}" > src/locale/en.json
 
       - name: Upload en.json to Crowdin
         uses: crowdin/[email protected]

.github/workflows/pr-validation.yml

@@ -206,18 +206,4 @@ jobs:
         if: ${{ github.event.pull_request.head.repo.full_name == github.repository && github.actor != 'dependabot[bot]' }}
         id: deploy-url
         run: |
-          echo "url=https://pr.dim.gg/${{ github.event.number }}/" >> $GITHUB_OUTPUT
-
-  validation-complete:
-    needs: [test, lint, build]
-    runs-on: ubuntu-latest
-    timeout-minutes: 5
-    if: always()
-    steps:
-      - name: Check validation results
-        run: |
-          if [[ "${{ needs.test.result }}" == "failure" ]] || [[ "${{ needs.lint.result }}" == "failure" ]] || [[ "${{ needs.build.result }}" == "failure" ]]; then
-            echo "::error::PR validation failed"
-            exit 1
-          fi
-          echo "::notice::✅ All PR validations passed successfully!"
+          echo "url=https://pr.dim.gg/${{ github.event.number }}/" >> $GITHUB_OUTPUT