i18n gha updates

Author: delphiactual

.github/workflows/i18n-bot-download.yml

@@ -1,11 +1,13 @@
 # This workflow runs every Saturday @ 1900 UTC (NOON PST)
 name: i18n download bot
+
 on:
   workflow_dispatch:
   schedule:
     - cron: "0 19 * * 6"
+
 jobs:
-  build:
+  download:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout DIM
@@ -14,16 +16,7 @@ jobs:
           ref: ${{ github.head_ref }}
           token: ${{ secrets.I18N_PAT }}
 
-      - uses: pnpm/action-setup@v4
-
-      - name: Setup Node
-        uses: actions/setup-node@v6
-        with:
-          node-version-file: '.nvmrc'
-          cache: pnpm
-
-      - name: Install
-        run: pnpm install --frozen-lockfile --prefer-offline
+      - uses: ./.github/actions/setup-pnpm
 
       - name: Download updated i18n files
         uses: crowdin/[email protected]
@@ -40,30 +33,31 @@ jobs:
           CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: sort locale json
+      - name: Sort locale JSON files
         run: |
           allLocales=("en" "de" "es" "esMX" "fr" "it" "ja" "ko" "pl" "ptBR" "ru" "zhCHS" "zhCHT")
-          for lang in ${allLocales[@]}; do
-            jq -S . src/locale/$lang.json > src/locale/sorted_$lang.json && mv src/locale/sorted_$lang.json src/locale/$lang.json
+          for lang in "${allLocales[@]}"; do
+            jq -S . "src/locale/$lang.json" > "src/locale/sorted_$lang.json" && \
+            mv "src/locale/sorted_$lang.json" "src/locale/$lang.json"
           done
 
-      - name: build browsercheck utils
+      - name: Build browsercheck utils
         run: pnpm bcu
 
-      - name: porcelain check
+      - name: Check for changes
         uses: dorny/paths-filter@v3
         id: filter
         with:
           base: HEAD
           filters: |
             changed:
-              - '**'
+              - 'src/locale/*.json'
 
       - name: Commit files
-        if: steps.filter.outputs.changed
+        if: steps.filter.outputs.changed == 'true'
         uses: stefanzweifel/git-auto-commit-action@v7
         with:
-          commit_message: i18n
+          commit_message: "i18n: Update translations from Crowdin"
           commit_user_name: DIM i18n Bot
           commit_user_email: [email protected]
           commit_author: DIM i18n Bot <[email protected]>

.github/workflows/i18n-bot-upload.yml

@@ -1,7 +1,7 @@
 # This workflow runs whenever locale/en.json is updated on the master branch
 # It updates crowdin with new translation strings
-# and notifies the #i18n @i18n in Discord of the new translations.
 name: i18n upload bot
+
 on:
   workflow_dispatch:
   push:
@@ -10,16 +10,18 @@ on:
     branches: [master]
 
 jobs:
-  build:
+  upload:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout DIM
         uses: actions/checkout@v6
 
       - name: Sort en.json
-        run: dimJSON="$(jq -S . src/locale/en.json)" && echo "${dimJSON}" > src/locale/en.json
+        run: |
+          sorted=$(jq -S . src/locale/en.json)
+          echo "$sorted" > src/locale/en.json
 
-      - name: Upload updated en.json to crowdin
+      - name: Upload en.json to Crowdin
         uses: crowdin/[email protected]
         with:
           upload_sources: true
@@ -31,7 +33,7 @@ jobs:
           CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: porcelain check
+      - name: Check for changes
         uses: dorny/paths-filter@v3
         id: filter
         with:

.github/workflows/i18n-update.yml

@@ -8,30 +8,20 @@ on:
       - 'src/locale/en.json'
 
 jobs:
-  i18n-update:
+  update:
     runs-on: ubuntu-latest
-
     steps:
       - uses: actions/checkout@v6
         with:
           fetch-depth: 3
           token: ${{ secrets.I18N_PAT }}
 
-      - uses: pnpm/action-setup@v4
-
-      - name: Setup Node
-        uses: actions/setup-node@v6
-        with:
-          node-version-file: '.nvmrc'
-          cache: pnpm
-
-      - name: Install
-        run: pnpm install --frozen-lockfile --prefer-offline
+      - uses: ./.github/actions/setup-pnpm
 
-      - name: pnpm i18n
+      - name: Run i18n update
         run: pnpm i18n
 
       - name: Commit files
         uses: stefanzweifel/git-auto-commit-action@v7
         with:
-          commit_message: Apply i18n updates
+          commit_message: "i18n: Apply automated updates"