refactor: constant 정리 및 주석 제거

Author: freeskyES

Hippo/Features/Vision/Runtime/VoiceControlManager+Executor.swift

@@ -2,11 +2,24 @@
 //  VoiceControlManager+Executor.swift
 //  Hippo
 //
+//  VoiceCommandExecutor implementation for VoiceControlManager
+//
 
 import Foundation
 
+// MARK: - VoiceCommandExecutor
+
 extension VoiceControlManager: VoiceCommandExecutor {
 
+    /// Execute voice command intent
+    ///
+    /// Maps voice command intents to concrete actions:
+    /// - Menu control (open/close)
+    /// - Video control (show/hide endoscope)
+    /// - Entity manipulation (rotate)
+    ///
+    /// - Parameter intent: The command intent to execute
+    /// - Throws: VoiceControlError if execution fails
     public func execute(_ intent: VoiceCommandIntent) async throws {
         switch intent {
         case .closeMenu:

Hippo/Features/Vision/Runtime/VoiceControlManager.swift

@@ -13,50 +13,57 @@ final class VoiceControlManager {
     let opacityManager: OpacityManager
     let dataViewModel: OperationViewModel
     let windowController: WindowController
-    
-    init(runtime: ImmersiveSceneRuntime, immersiveViewModel: ImmersiveViewModel, opacityManager: OpacityManager, dataViewModel: OperationViewModel, windowController: WindowController) {
+
+    init(
+        runtime: ImmersiveSceneRuntime,
+        immersiveViewModel: ImmersiveViewModel,
+        opacityManager: OpacityManager,
+        dataViewModel: OperationViewModel,
+        windowController: WindowController
+    ) {
         self.runtime = runtime
         self.immersiveViewModel = immersiveViewModel
         self.opacityManager = opacityManager
         self.dataViewModel = dataViewModel
         self.windowController = windowController
     }
-    
+
     func openHeadController() {
         immersiveViewModel.openMenuSetting(windowController: windowController)
     }
-    
+
     func closeHeadController() {
         immersiveViewModel.closeMenuSetting(windowController: windowController)
     }
-    
+
     func openEndoscopicView() {
-        //if immersiveViewModel.isEndoscopicActive {
+        if !immersiveViewModel.isEndoscopicActive {
             immersiveViewModel.toggleEndoscope()
-        //}
+        }
     }
-    
+
     func closeEndoscopicView() {
-        //if !immersiveViewModel.isEndoscopicActive {
+        if immersiveViewModel.isEndoscopicActive {
             immersiveViewModel.toggleEndoscope()
-        //}
+        }
     }
-    
+
     // 등록된 엔티티 중 i번째 엔티티 생성
     func addEntity(index: Int) {
         var fileURLs: [URL] {
             dataViewModel.state.operation?.assets.map { $0.fileURL } ?? []
         }
-        
-        guard let selectedURL = fileURLs.indices.contains(index) ? fileURLs[index] : nil else {
+
+        guard
+            let selectedURL = fileURLs.indices.contains(index)
+                ? fileURLs[index] : nil
+        else {
             return
         }
-        
+
         Task {
             await runtime.placeEntity(url: selectedURL)
         }
     }
-    
-    
 
 }

Hippo/Features/Vision/UI/VoiceControl/Helpers/WakeWordListener.swift

@@ -1,44 +1,15 @@
-//
-//  WakeWordListener.swift
-//  Hippo
-//
-//  Presentation helper for continuous wake word detection
-//
-//  Responsibilities:
-//  - Continuously listen for wake words in Standby mode
-//  - Notify when wake word is detected
-//  - Manage listening lifecycle (start/stop)
-//
-//  This is a presentation-layer helper, not a domain service.
-//  Wake word detection is specific to this app's UX flow.
-//
-
 import Foundation
 import Dependencies
 
-/// Wake Word Listener
-///
-/// A lightweight helper that continuously listens for wake words
-/// (e.g., "Hippo", "히포") and notifies when detected.
-///
-/// **Usage:**
-/// ```swift
-/// let listener = WakeWordListener()
-/// listener.start(wakeWords: ["hippo", "히포"]) {
-///     print("Wake word detected!")
-/// }
-/// // Later...
-/// listener.stop()
-/// ```
-///
-/// **Design rationale:**
-/// - Lives in Presentation layer (not Domain) because wake word detection
-///   is specific to this app's UX, not a reusable domain concept
-/// - Uses SpeechRecognitionService (Domain) for actual STT
-/// - Implements the continuous listening loop and wake word matching
 @MainActor
 final class WakeWordListener {
 
+    // MARK: - Constants
+
+    private enum Constants {
+        static let errorRetryDelay: UInt64 = 500_000_000  // 0.5 seconds
+    }
+
     // MARK: - Dependencies
 
     @Dependency(\.speechRecognitionService) private var speechRecognition
@@ -47,13 +18,9 @@ final class WakeWordListener {
 
     private var listeningTask: Task<Void, Never>?
 
-    // MARK: - Public API
+    // MARK: - Public Methods
 
     /// Start listening for wake words
-    ///
-    /// This method continuously listens for the specified wake words.
-    /// When detected, it calls the `onDetected` callback and stops listening.
-    ///
     /// - Parameters:
     ///   - wakeWords: Array of wake words to detect (case-insensitive)
     ///   - onDetected: Callback called when wake word is detected
@@ -82,19 +49,14 @@ final class WakeWordListener {
 
                 } catch {
                     print("⚠️ [WakeWordListener] Error: \(error)")
-                    // Continue listening even on error, with small delay
-                    // to avoid tight loop on repeated errors
-                    try? await Task.sleep(nanoseconds: 500_000_000)  // 0.5 seconds
+                    try? await Task.sleep(nanoseconds: Constants.errorRetryDelay)
                 }
             }
 
             print("🎧 [WakeWordListener] Stopped listening")
         }
     }
 
-    /// Stop listening for wake words
-    ///
-    /// This cancels the ongoing wake word detection task.
     func stop() {
         listeningTask?.cancel()
         listeningTask = nil

Hippo/Features/Vision/UI/VoiceControl/ViewModels/VoiceControlUIState.swift

@@ -18,14 +18,24 @@ import Foundation
 /// All UI-related logic (error messages, feedback) is encapsulated here.
 public struct VoiceControlUIState: Equatable {
 
-    // MARK: - Properties
+    // MARK: - Properties - State
 
     /// Core domain state
     public var state: VoiceControlState
 
+    /// Type of current feedback message (for styling)
+    public var feedbackType: FeedbackType = .info
+
+    // MARK: - Properties - Messages
+
     /// Current feedback message to display to user
     public var feedbackMessage: String?
 
+    /// Last error message (for user feedback)
+    public var lastErrorMessage: String?
+
+    // MARK: - Properties - Transcriptions
+
     /// Real-time partial transcription (shown while listening)
     public var partialTranscription: String?
 
@@ -35,15 +45,11 @@ public struct VoiceControlUIState: Equatable {
     /// Last parsed intent (for debugging/UI feedback)
     public var lastParsedIntent: String?
 
-    /// Last error message (for user feedback)
-    public var lastErrorMessage: String?
+    // MARK: - Properties - Processing
 
     /// Whether currently processing (recognition or parsing)
     public var isProcessing: Bool = false
 
-    /// Type of current feedback message (for styling)
-    public var feedbackType: FeedbackType = .info
-
     // MARK: - Initialization
 
     public init(

Hippo/Features/Vision/UI/VoiceControl/ViewModels/VoiceControlViewModel.swift

@@ -42,6 +42,22 @@ import Observation
 @Observable
 public final class VoiceControlViewModel {
 
+    // MARK: - Constants
+
+    private enum Constants {
+        /// Delay after wake word detection to clear audio buffer
+        static let wakeWordBufferDelay: UInt64 = 800_000_000  // 0.8 seconds
+
+        /// Duration to show success message
+        static let successMessageDuration: UInt64 = 1_500_000_000  // 1.5 seconds
+
+        /// Duration to show error message before retry
+        static let errorMessageDuration: UInt64 = 1_000_000_000  // 1 second
+
+        /// Retry deadline in seconds
+        static let retryDeadlineSeconds: TimeInterval = 3.0
+    }
+
     // MARK: - Dependencies
 
     @ObservationIgnored @Dependency(\.speechRecognitionService) private var speechRecognition
@@ -164,7 +180,7 @@ public final class VoiceControlViewModel {
 
         // Add small delay to clear audio buffer and show feedback
         Task { @MainActor in
-            try? await Task.sleep(nanoseconds: 800_000_000)  // 0.8 seconds
+            try? await Task.sleep(nanoseconds: Constants.wakeWordBufferDelay)
             print("🎯 [VoiceControl] Audio buffer cleared, starting command listening")
             self.startListeningFlow()
         }
@@ -305,10 +321,10 @@ public final class VoiceControlViewModel {
         uiState.lastParsedIntent = nil
 
         // Show success message briefly
-        try? await Task.sleep(nanoseconds: 1_500_000_000)  // 1.5 seconds
+        try? await Task.sleep(nanoseconds: Constants.successMessageDuration)
 
         // Success: Return to idle
-        print("✅ [VoiceControl] Flow completed → Idle")
+        print(" [VoiceControl] Flow completed → Idle")
         clearUIState()
         uiState.setState(.idle)
     }
@@ -352,10 +368,9 @@ public final class VoiceControlViewModel {
 
     /// Start retry flow with automatic timeout
     ///
-    /// Shows error message for 1 second, then automatically retries
-    /// within 3 seconds deadline.
+    /// Shows error message briefly, then automatically retries within deadline.
     private func startRetryFlow() {
-        let deadline = Date().addingTimeInterval(3.0)
+        let deadline = Date().addingTimeInterval(Constants.retryDeadlineSeconds)
         uiState.setState(.retry(attempt: 1, deadline: deadline))
 
         // Cancel any existing retry task
@@ -365,8 +380,8 @@ public final class VoiceControlViewModel {
         retryTask = Task { @MainActor [weak self] in
             guard let self else { return }
 
-            // Show error message for 1 second
-            try? await Task.sleep(nanoseconds: 1_000_000_000)
+            // Show error message briefly
+            try? await Task.sleep(nanoseconds: Constants.errorMessageDuration)
 
             // Early return if state changed
             guard case .retry = self.uiState.state else { return }

Hippo/Features/Vision/UI/VoiceControl/Views/VoiceControlOverlay.swift

@@ -9,36 +9,6 @@
 //  - Show transcription results (for debugging/feedback)
 //  - Provide visual feedback during different states
 //
-//  Usage Example:
-//  ```swift
-//  struct ImmersiveView: View {
-//      @State private var voiceControlManager: VoiceControlManager
-//      @State private var voiceControlVM: VoiceControlViewModel
-//
-//      init(manager: VoiceControlManager) {
-//          _voiceControlManager = State(initialValue: manager)
-//          _voiceControlVM = State(initialValue: VoiceControlViewModel(
-//              commandExecutor: manager
-//          ))
-//      }
-//
-//      var body: some View {
-//          ZStack {
-//              // Main 3D content
-//              RealityView { ... }
-//
-//              // Voice control button (triggers voice control)
-//              VoiceControlMenuButton(manager: voiceControlManager) {
-//                  // Toggle menu action
-//              }
-//
-//              // Voice control feedback overlay (shows state messages)
-//              VoiceControlOverlay(viewModel: voiceControlVM)
-//          }
-//      }
-//  }
-//  ```
-//
 //  Note: Button and Overlay should share the same VoiceControlViewModel instance
 //        for synchronized state updates.
 //

Hippo/Shared/Data/VoiceControl/SpeechRecognition/AppleSpeechRecognitionService.swift

@@ -27,6 +27,14 @@ import AVFoundation
 @MainActor
 public final class AppleSpeechRecognitionService: SpeechRecognitionService {
 
+    // MARK: - Constants
+
+    private enum Constants {
+        static let audioBufferSize: AVAudioFrameCount = 1024
+        static let recognitionTimeoutNanoseconds: UInt64 = 7_000_000_000  // 7 seconds
+        static let errorRetryDelayNanoseconds: UInt64 = 500_000_000  // 0.5 seconds
+    }
+
     // MARK: - Properties
 
     private let speechRecognizer: SFSpeechRecognizer
@@ -145,7 +153,7 @@ private extension AppleSpeechRecognitionService {
 
         inputNode.installTap(
             onBus: 0,
-            bufferSize: 1024,
+            bufferSize: Constants.audioBufferSize,
             format: recordingFormat
         ) { buffer, _ in
             request.append(buffer)
@@ -251,7 +259,7 @@ private extension AppleSpeechRecognitionService {
             guard let self = self else { return }
 
             // Wait 7 seconds (increased from 5 to allow full command phrases)
-            try? await Task.sleep(nanoseconds: 7_000_000_000)
+            try? await Task.sleep(nanoseconds: Constants.recognitionTimeoutNanoseconds)
 
             guard !state.hasResumed else { return }
             state.hasResumed = true