Sea ice sensitivity to GMST - Calculate from observational datasets#4220
Sea ice sensitivity to GMST - Calculate from observational datasets#4220NParsonsMO wants to merge 83 commits into
Conversation
- Removed obs from Roach-style graphic (left description for reference). - Fed in model datasets from recipe differently to allow for obs having a different variable. To do: - Calculate and plot the obs. - Print the obs trend values.
|
please give the PR a suitable title, when you have a minute (even if it's a draft) 😁 |
…-recipe-retry Attempt to fix error in Install
NParsonsMO
changed the title
Co-authored-by: Alistair Sellar <16133375+alistairsellar@users.noreply.github.com>
| start_day: 1 | ||
| start_month: 1 | ||
| start_year: 1979 | ||
| start_year: &data_start 1979 |
There was a problem hiding this comment.
It did not that I could see.
OK. In which case (and reflecting an offline comment from Ed) it could be more obvious to specify the dates in the dataset specifications. (Still sticking with the hard-wiring approach.
I've changed where the years are set in 2bff0ef. I've added a warning if not all periods are the same in 2971258. If nobody specifies any years anywhere then the script will fail because ESMValTool will just pre-process all available data, and then when it tries to calculate the regression of OSI-SAF data over, say, HadCRUT5 data the dimensions don't match, so I've added a note to the documentation in 26b7d2f. |
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
Thanks @NParsonsMO, code looks good to me! I only have a couple of minor comments.
Please run pre-commit run --all on your code, this should also fix most of the Codacy issues.
Thanks!
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Thank-you! Of the two remaining Codacy issues:
|
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
I disagree that the Iris constraint should have a comma (though feel free to tell me it should!)
Sounds good!
The plotting code does have a lot of statements, but I couldn't think how to write it more neatly while still being readable and potentially plotting the two different time periods wanted for the CMIP7 version.
Sounds good to me as well!
Thanks for addressing my comments, just one more tiny comment.
alistairsellar
left a comment
alistairsellar
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments.
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Hi @schlunma, are you willing/able to merge this? Or are there more steps I need to take / should it be a non-reviewer? |
|
@ESMValGroup/technical-lead-development-team Is anyone able to merge this please? Thank-you! |
4 participants
Added capacity to calculate trends from observational datasets (though also keeping currently provided values, as Notz-style includes a "plausible" range that is beyond scope).
Observations are shown as squares.
Annual trend in siconc for NOAA dataset is slightly different between this and Roach's figures, 0.01677... vs 0.01692....
Annual trends for GMST were taken as one average in Roach's plots, so will not be identical.
The published plot used data up to 2018, but we only use up to 2014.
The hatching criterion for the Roach-style plot is now consistent with the published plot.
Added ability to plot two different time periods in Notz-style plot, ready for use with CMIP7 datasets.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
New or updated data reformatting script
To help with the number of pull requests: