feat(Player):``Player::RemoveItem(ItemType, bool)`` method by Mr-Baguetter · Pull Request #801 · ExMod-Team/EXILED

Mr-Baguetter · 2026-04-03T01:51:26Z

…nstance

Description

Added a new Player::RemoveItem method that uses ItemType instead of a item instance

Types of changes

Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentations

Submission checklist

[x ] I have checked the project can be compiled
[ x] I have tested my changes and it worked as expected

…nstance

louis1706

can you also add a method for DropItem(ItemType

Mr-Baguetter · 2026-04-06T20:01:52Z

can you also add a method for DropItem(ItemType

Ive added these

Unbistrackted · 2026-04-07T19:07:15Z

@louis1706 is it stupid but or adding something like "allInstances/allOccurrences" is good?

Like I can see myself needing that, just so I don't need to type a for loop

Someone-193

Maybe some of the docs could be improved, but it looks fine

Unbistrackted · 2026-04-11T18:31:19Z

@Mr-Baguetter, talked with yamato and it should be ok abt adding the allOccurrences, just made this one fast if you want change it

        /// <summary>
        /// Drops an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.
        /// </summary>
        /// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>
        /// <param name="isThrown">Is the item Thrown?.</param>
        /// <param name="allOccurrences">If it should drop all matching occurrences.</param>
        /// <returns>A value indicating whether the <see cref="Item"/> was dropped.</returns>
        public bool DropItem(ItemType item, bool isThrown = false, bool allOccurrences = false)
        {
            List<Item> itemsToDrop = Items.Where(i => i?.Type == item).ToList();

            if (itemsToDrop.Count == 0)
                return false;

            if (!allOccurrences)
            {
                DropItem(itemsToDrop[0], isThrown);
                return true;
            }

            foreach (Item i in itemsToDrop)
                DropItem(i, isThrown);

            return true;
        }

        /// <summary>
        /// Drops an item from the player's inventory.
        /// </summary>
        /// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>
        /// <param name="allOccurrences">If it should drop all matching occurrences.</param>
        /// <returns>A list of dropped <see cref="Pickup"/>.</returns>
        public List<Pickup> DropItem(ItemType item, bool allOccurrences = false)
        {
            List<Item> itemsToDrop = Items.Where(i => i?.Type == item).ToList();
            List<Pickup> pickups = new();

            if (itemsToDrop.Count == 0)
                return pickups;

            if (!allOccurrences)
            {
                pickups.Add(DropItem(itemsToDrop[0]));
                return pickups;
            }

            foreach (Item i in itemsToDrop)
                pickups.Add(DropItem(i));

            return pickups;
        }

        /// <summary>
        /// Removes an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.
        /// </summary>
        /// <param name="item">The specified <see cref="ItemType"/> to be removed.</param>
        /// <param name="destroy">Whether to destroy the item.</param>
        /// <param name="allOccurrences">If it should drop all matching occurrences.</param>
        /// <returns>A value indicating whether the <see cref="Item"/> was removed.</returns>
        public bool RemoveItem(ItemType item, bool destroy = true, bool allOccurrences = false)
        {
            List<Item> itemsToRemove = Items.Where(i => i?.Type == item).ToList();

            if (itemsToRemove.Count == 0)
                return false;

            if (!allOccurrences)
            {
                RemoveItem(itemsToRemove[0], destroy);
                return true;
            }

            foreach (Item i in itemsToRemove)
                RemoveItem(i, destroy);

            return true;
        }

VALERA771

Lgtm

VALERA771 · 2026-04-11T19:06:59Z

Nvm, I'll wait for y'all to do something

Unbistrackted · 2026-04-11T19:45:17Z

Following @louis1706's suggestion in my dms of using amount instead of allOccurrences
idk how to do reviews so that's why I'm sending the code here lul

        /// <summary>
        /// Drops an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.
        /// </summary>
        /// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>
        /// <param name="isThrown">Is the item Thrown?.</param>
        /// <param name="amount">The amount of matching occurrences that will be removed.</param>
        /// <returns>A value indicating whether the <see cref="Item"/> was dropped.</returns>
        public bool DropItem(ItemType item, bool isThrown = false, int amount = 1)
        {
            if (amount <= 0)
                return false;

            List<Item> itemsToDrop = Items.Where(i => i?.Type == item).ToList();

            if (itemsToDrop.Count == 0)
                return false;

            foreach (Item i in itemsToDrop)
                DropItem(i, isThrown);

            return true;
        }

        /// <summary>
        /// Drops an item from the player's inventory.
        /// </summary>
        /// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>
        /// <param name="amount">The amount of matching occurrences that will be removed.</param>
        /// <returns>A list of dropped <see cref="Pickup"/>s.</returns>
        public List<Pickup> DropItem(ItemType item, int amount = 1)
        {
            List<Pickup> pickups = new();

            if (amount <= 0)
                return pickups;

            List<Item> itemsToDrop = Items.Where(i => i?.Type == item).Take(amount).ToList();

            if (itemsToDrop.Count == 0)
                return pickups;

            foreach (Item i in itemsToDrop)
                pickups.Add(DropItem(i));

            return pickups;
        }

        /// <summary>
        /// Removes an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.
        /// </summary>
        /// <param name="item">The specified <see cref="ItemType"/> to be removed.</param>
        /// <param name="destroy">Whether to destroy the item.</param>
        /// <param name="amount">The amount of matching occurrences that will be removed.</param>
        /// <returns>A value indicating whether the <see cref="Item"/> was removed.</returns>
        public bool RemoveItem(ItemType item, bool destroy = true, int amount = 1)
        {
            if (amount <= 0)
                return false;

            List<Item> itemsToRemove = Items.Where(i => i?.Type == item).Take(amount).ToList();

            if (itemsToRemove.Count == 0)
                return false;

            foreach (Item i in itemsToRemove)
                RemoveItem(i, destroy);

            return true;
        }

Unbistrackted · 2026-04-17T11:34:52Z

+        /// <summary>
+        /// Drops an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.
+        /// </summary>
+        /// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>
+        /// <param name="isThrown">Is the item Thrown?.</param>
+        /// <returns>A value indicating whether the <see cref="Item"/> was dropped.</returns>
+        public bool DropItem(ItemType item, bool isThrown = false)
+        {
+            Item itemtodrop = Items.FirstOrDefault(tempItem => tempItem.Type == item);
+            if (itemtodrop == null)
+                return false;
+
+            DropItem(itemtodrop, isThrown);
+            return true;
+        }
+
+        /// <summary>
+        /// Drops an item from the player's inventory.
+        /// </summary>
+        /// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>
+        /// <returns>dropped <see cref="Pickup"/>.</returns>
+        public Pickup DropItem(ItemType item)
+        {
+            Item itemtodrop = Items.FirstOrDefault(tempItem => tempItem.Type == item);
+            if (itemtodrop == null)
+                return null;
+
+            return Pickup.Get(Inventory.ServerDropItem(itemtodrop.Serial));
+        }
+


Suggested change

/// <summary>

/// Drops an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.

/// </summary>

/// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>

/// <param name="isThrown">Is the item Thrown?.</param>

/// <returns>A value indicating whether the <see cref="Item"/> was dropped.</returns>

public bool DropItem(ItemType item, bool isThrown = false)

{

Item itemtodrop = Items.FirstOrDefault(tempItem => tempItem.Type == item);

if (itemtodrop == null)

return false;

DropItem(itemtodrop, isThrown);

return true;

}

/// <summary>

/// Drops an item from the player's inventory.

/// </summary>

/// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>

/// <returns>dropped <see cref="Pickup"/>.</returns>

public Pickup DropItem(ItemType item)

{

Item itemtodrop = Items.FirstOrDefault(tempItem => tempItem.Type == item);

if (itemtodrop == null)

return null;

return Pickup.Get(Inventory.ServerDropItem(itemtodrop.Serial));

}

/// <summary>

/// Drops an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.

/// </summary>

/// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>

/// <param name="isThrown">Whether the item should be thrown.</param>

/// <param name="amount">The number of matching items to remove.</param>

/// <returns>A value indicating whether the <see cref="Item"/> was dropped.</returns>

public bool DropItem(ItemType item, bool isThrown = false, int amount = 1)

{

if (amount <= 0)

return false;

List<Item> itemsToDrop = Items.Where(i => i?.Type == item).Take(amount).ToList();

if (itemsToDrop.Count == 0)

return false;

foreach (Item i in itemsToDrop)

DropItem(i, isThrown);

return itemsToDrop.Count > 0;

}

/// <summary>

/// Drops an item from the player's inventory.

/// </summary>

/// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>

/// <param name="amount">The number of matching items to remove.</param>

/// <returns>A list of dropped <see cref="Pickup"/>s.</returns>

public List<Pickup> DropItem(ItemType item, int amount = 1)

{

List<Pickup> pickups = new();

if (amount <= 0)

return pickups;

List<Item> itemsToDrop = Items.Where(i => i?.Type == item).Take(amount).ToList();

foreach (Item i in itemsToDrop)

pickups.Add(DropItem(i));

return pickups;

}

Unbistrackted · 2026-04-17T11:37:39Z

+        /// <summary>
+        /// Removes an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.
+        /// </summary>
+        /// <param name="item">The specified <see cref="ItemType"/> to be removed.</param>
+        /// <param name="destroy">Whether to destroy the item.</param>
+        /// <returns>A value indicating whether the <see cref="Item"/> was removed.</returns>
+        public bool RemoveItem(ItemType item, bool destroy = true)
+        {
+            Item itemtoremove = Items.FirstOrDefault(tempItem => tempItem.Type == item);
+            if (itemtoremove == null)
+                return false;
+
+            RemoveItem(itemtoremove, destroy);
+            return true;
+        }
+


Suggested change

/// <summary>

/// Removes an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.

/// </summary>

/// <param name="item">The specified <see cref="ItemType"/> to be removed.</param>

/// <param name="destroy">Whether to destroy the item.</param>

/// <returns>A value indicating whether the <see cref="Item"/> was removed.</returns>

public bool RemoveItem(ItemType item, bool destroy = true)

{

Item itemtoremove = Items.FirstOrDefault(tempItem => tempItem.Type == item);

if (itemtoremove == null)

return false;

RemoveItem(itemtoremove, destroy);

return true;

}

/// <summary>

/// Removes an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.

/// </summary>

/// <param name="item">The specified <see cref="ItemType"/> to be removed.</param>

/// <param name="destroy">Whether to destroy the item.</param>

/// <param name="amount">The number of matching items to remove.</param>

/// <returns>A value indicating whether the <see cref="Item"/> was removed.</returns>

public bool RemoveItem(ItemType item, bool destroy = true, int amount = 1)

{

if (amount <= 0)

return false;

List<Item> itemsToRemove = Items.Where(i => i?.Type == item).Take(amount).ToList();

if (itemsToRemove.Count == 0)

return false;

foreach (Item i in itemsToRemove)

RemoveItem(i, destroy);

return true;

}

Mr-Baguetter added 5 commits April 2, 2026 20:38

Add: Player::RemoveItem method that uses ItemType instead of a item i…

0b96f4b

…nstance

Updated parameter name

f138d36

Updated parameter name

eb175ff

Merge branch 'master' of https://github.com/Mr-Baguetter/EXILED

a910990

Revert param change

8fba1b7

github-actions bot assigned Mr-Baguetter Apr 3, 2026

github-actions bot added the API label Apr 3, 2026

louis1706 changed the title ~~New Player::RemoveItem method~~ feay:New Player::RemoveItem method Apr 3, 2026

Merge branch 'dev' into master

7dd8302

louis1706 reviewed Apr 3, 2026

View reviewed changes

louis1706 changed the title ~~feay:New Player::RemoveItem method~~ feat(Player):Player::RemoveItem(ItemType, bool) method Apr 4, 2026

Mr-Baguetter added 2 commits April 6, 2026 14:38

Added Player::DropItem(ItemType) methods

7aefc66

Merge branch 'master' of https://github.com/Mr-Baguetter/EXILED

09169f4

Someone-193 approved these changes Apr 9, 2026

View reviewed changes

VALERA771 approved these changes Apr 11, 2026

View reviewed changes

Unbistrackted suggested changes Apr 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Player):`Player::RemoveItem(ItemType, bool)` method#801

feat(Player):`Player::RemoveItem(ItemType, bool)` method#801
Mr-Baguetter wants to merge 8 commits intoExMod-Team:devfrom
Mr-Baguetter:master

Mr-Baguetter commented Apr 3, 2026

Uh oh!

louis1706 left a comment

Uh oh!

Mr-Baguetter commented Apr 6, 2026

Uh oh!

Unbistrackted commented Apr 7, 2026 •

edited

Loading

Uh oh!

Someone-193 left a comment

Uh oh!

Unbistrackted commented Apr 11, 2026 •

edited

Loading

Uh oh!

VALERA771 left a comment

Uh oh!

VALERA771 commented Apr 11, 2026

Uh oh!

Unbistrackted commented Apr 11, 2026 •

edited

Loading

Uh oh!

Unbistrackted Apr 17, 2026

Uh oh!

Unbistrackted Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Mr-Baguetter commented Apr 3, 2026

Description

Types of changes

Submission checklist

Uh oh!

louis1706 left a comment

Choose a reason for hiding this comment

Uh oh!

Mr-Baguetter commented Apr 6, 2026

Uh oh!

Unbistrackted commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Someone-193 left a comment

Choose a reason for hiding this comment

Uh oh!

Unbistrackted commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VALERA771 left a comment

Choose a reason for hiding this comment

Uh oh!

VALERA771 commented Apr 11, 2026

Uh oh!

Unbistrackted commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Unbistrackted Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Unbistrackted Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Unbistrackted commented Apr 7, 2026 •

edited

Loading

Unbistrackted commented Apr 11, 2026 •

edited

Loading

Unbistrackted commented Apr 11, 2026 •

edited

Loading