Refactoring #4
Open
Refactoring #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramazansakin
commented
Oct 22, 2020
ramazansakin
commented
- Lombok integration
- SonarLint issues fixed
- README up
Member
|
@ramazansakin thanks for the PR, looks good, but Travis CI fails to build it. Seems like the JDK is too old. Could you try updating .travis.yaml to something like jdk: openjdk10 and see if it compiles? |
Author
|
@szantopeter ok , I 'll update soon. |
Member
|
@ramazansakin have you had a chance to look into this? |
Author
Not yet @szantopeter, so bussy, if you can , please. Thx |
Author
|
Hi @szantopeter, So sorry for last answer but I tried a few times to build via travis but I couldnt get a success build. |
jdk build version up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.