Allow multiple implementations of JAX-RS for all providers #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ious JAX-RS versions and fix jackson-jaxrs-xml-provider module name
Member
|
@fenixcitizen We'd probably wants this against 2.12 branch, although I guess I should be able to cherry-pick it easily from master if need be. @GedMarc Seems to make sense (rolling out defs json has to other formats). WDYT? |
| @@ -1,13 +1,15 @@ | |||
| // Generated 02-Apr-2019 using Moditect maven plugin | |||
| module com.fasterxml.jackson.jaxrs.yaml { | |||
| module com.fasterxml.jackson.jaxrs.xml { | |||
Member
|
I think this makes sense, wrt my understand so will merge (since no code is changed, no need for CLA either). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
please consider merging this PR which extends #121 to all providers, so that they could be leveraged in modularized applications using newer version of JAX-RS while remaining backward compatible.
I've encountered the problem with
jackson-jaxrs-xml-providerbut it makes sense to fix them all in one go just likejackson-jaxrs-json-providerwas. It should also be fine to port it to2.11and2.12branches if you like. Please also note that I've changed the name ofjackson-jaxrs-xml-providermodule fromcom.fasterxml.jackson.jaxrs.yamltocom.fasterxml.jackson.jaxrs.xml. All other seem to be consistent.Finally, please note that #124 seems to be breaking the
module-info.javaof all subprojects. After merging this PR, #124 should be adjusted so that it doesn't change anymodule-info.javafile.Let me know what you think! 😄