FWSS support for simplified DataSet terminations and cleanup for GA

[BigLep]

https://www.notion.so/filecoindev/Data-Set-Terminations-Clean-up-360dc41950c1801ebf0aff017a322e7f

Summary

Implementation of the FWSS (FilecoinWarmStorageService) contract changes for the data set termination and clean-up design. This is the filecoin-services side of the work; see sibling issues for other repos.

FWSS contract changes

712 typehash rename

• DeleteDataSet(uint256 dataSetId) → TerminateService(uint256 dataSetId) in test fixtures and signature verification helpers (test(fwss): replace DeleteDataSet 712 sig with TerminateService #480).
• Move TERMINATE_SERVICE_TYPEHASH from the test contract into SignatureVerificationLib (production code) when the terminateService impl lands. (feat: termination extra data param #485)

terminateService changes

• Accept extraData carrying client EIP-712 signature for SP-relayed termination. (feat: termination extra data param #485)
• When valid client 712 present: collect client termination fee via one-time payment on existing rail, call modifyRailLockup(railId, 0, 0) to drop lockup period to zero for immediate finalisation. (separate issue Per-operation pricing for FilecoinWarmStorageService #469)
• When extraData empty: SP-initiated termination, 30-day lockup path, no client fee. (separate issue Per-operation pricing for FilecoinWarmStorageService #469)
• Move CDN rail termination out of terminateService — CDN rails now persist through the lockup window and terminate in dataSetDeleted instead. (separate issue Per-operation pricing for FilecoinWarmStorageService #469)

dataSetDeleted callback — two-path listener

• Normal path (SP calls, rail already terminated and finalised): existing cleanup, plus CDN rail termination moves here from terminateService. (separate issue Per-operation pricing for FilecoinWarmStorageService #469)
• Abandonment path (pdpEndEpoch == 0, 30d since last proof, any caller): FWSS performs inline rail tear-down (modifyRailLockup → terminateRail → settleRail), handles both funded and underfunded client states, then clears FWSS state. (separate issue Per-operation pricing for FilecoinWarmStorageService #469)

CDN rail lifecycle change

• CDN service persists through the storage lockup window (client keeps retrieval acceleration for what they paid for). (feat: operational pricing #488)
• CDN rails terminated in dataSetDeleted with a shorter lockup period (5 days) to give FilBeam a graceful settle window. (feat: operational pricing #488)
• Existing FilBeam rails with 30-day lockup left as-is; new ones created with shorter period. (feat: operational pricing #488)

Client termination fee

• Collected at terminateService when client 712 is present (client is provably involved). (separate issue Per-operation pricing for FilecoinWarmStorageService #469, and duplicate of above item)
• Fee compensates SP for gas; no link to state clean-up incentives. (separate issue Per-operation pricing for FilecoinWarmStorageService #469, and duplicate of above item)

Sibling issues

• PDPVerifier (cleanup bond, cleanupPieces): [pdp] Simplified DataSet terminations and cleanup for GA pdp#269
• Curio (new tasks, HTTP endpoint, reconciliation): pdp: Curio support for simplified DataSet terminations and cleanup for GA filecoin-project/curio#1231
• Synapse SDK (712 flow, pre-check, typehash rename): Synapse support for simplified DataSet terminations and cleanup for GA synapse-sdk#792
• Design issue: Termination clarifications / simplifications design #477

[BigLep]

I know wome of the items are being addressed in #485

@wjmelements : can you denote which of the checklist items are handled by that PR please? You can just add it in parentheses after the item like was done for "DeleteDataSet(uint256 dataSetId) → TerminateService(uint256 dataSetId) in test fixtures and signature verification helpers"

Also, seeing all the items there are in this issue, do we really think the estimate is .5 dev days?

[wjmelements]

Also, seeing all the items there are in this issue, do we really think the estimate is .5 dev days?

0.5 is hilarious

[wjmelements]

Whoever can do it in 0.5 days should do it in 0.5 days

[wjmelements]

@BigLep I reviewed your checklist. Many of its items are duplicates of themselves or of #469. Is this a sub issue of #469?