From 38f4ce8c04fb59471489f9024ec18cfe0d357c60 Mon Sep 17 00:00:00 2001 From: TippyFlits Date: Tue, 7 Apr 2026 17:14:04 +0100 Subject: [PATCH 1/3] feat: standardise SP approval review tracking with issue template Introduces a standard SP approval review issue template in tpm-utils and updates the approval runbook to use it as the source of truth. Removes duplicated field definitions from the runbook and ensures all SP approval reviews are tracked consistently with clear triggers, UTC timestamps, investigation windows, diagnosis, and outcomes. The template captures: - review trigger and timing - failing metrics and thresholds - investigation window and maintenance context - communication with SPs - diagnosis and classification of issues - decision, actions taken, and supporting evidence This improves operational consistency, auditability, and handover between approvers as we approach mainnet production readiness. --- .github/ISSUE_TEMPLATE/sp-approval-review.md | 96 ++++++++++++++++++++ 1 file changed, 96 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/sp-approval-review.md diff --git a/.github/ISSUE_TEMPLATE/sp-approval-review.md b/.github/ISSUE_TEMPLATE/sp-approval-review.md new file mode 100644 index 0000000..9804dda --- /dev/null +++ b/.github/ISSUE_TEMPLATE/sp-approval-review.md @@ -0,0 +1,96 @@ +--- +name: SP Approval Review +about: Track a Storage Provider (SP) approval review and decision +title: "[SP Approval Review] f0xxxx" +labels: ["sp-approval-review"] +assignees: [] +--- + +## SP Approval Review + +### SP Details +- **SP ID:** +- **SP Name (optional):** + +--- + +### Review Trigger +- **Time review started (UTC):** +- **Trigger condition:** + + +--- + +### Metrics + +**Failing metric(s):** +- + +**Observed value(s):** +- + +**Threshold(s):** +- + +--- + +### Investigation Window +- **Investigation deadline (UTC):** +- **Within maintenance window?** Yes / No + +--- + +### Communication + +- **SP notified?** Yes / No +- **Channel used:** + + +- **SP response (if any):** + + +--- + +### Diagnosis + +**Current assessment:** +- [ ] SP-side issue +- [ ] Dealbot / tooling issue +- [ ] Network / external issue +- [ ] Unknown + +**Notes:** + + +--- + +### Outcome + +- [ ] Recovered within investigation window +- [ ] Unapproved + +- **Decision time (UTC):** + +--- + +### Actions Taken + +- [ ] SP remained approved +- [ ] SP unapproved +- [ ] Follow-up issue created +- [ ] Escalated + +--- + +### Links & Evidence + +- Dashboard (spdash): +- Dealbot runs: +- Logs / errors: +- Related issues: + +--- + +### Notes + + From 5e97f080ef398ba456436ab9a57fd0f3f3843eb3 Mon Sep 17 00:00:00 2001 From: TippyFlits Date: Mon, 18 May 2026 18:06:33 +0100 Subject: [PATCH 2/3] feat: generalise SP approval template to cover new approvals, breach reviews, and periodic checks Addresses @beck-8's feedback that the template should cover SP onboarding, not just breach reviews. Adds a Review Type selector at the top and marks breach-specific sections as conditional. Adds a Decision owner field to make ownership explicit in the issue body. --- .github/ISSUE_TEMPLATE/sp-approval-review.md | 43 +++++++++++++++----- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/sp-approval-review.md b/.github/ISSUE_TEMPLATE/sp-approval-review.md index 9804dda..85df07d 100644 --- a/.github/ISSUE_TEMPLATE/sp-approval-review.md +++ b/.github/ISSUE_TEMPLATE/sp-approval-review.md @@ -1,13 +1,23 @@ --- name: SP Approval Review -about: Track a Storage Provider (SP) approval review and decision -title: "[SP Approval Review] f0xxxx" +about: Track an SP approval decision — new approval, breach review, or periodic check +title: "[SP Approval] f0xxxx" labels: ["sp-approval-review"] assignees: [] --- ## SP Approval Review +### Review Type + +- [ ] **New approval** — SP is being approved for the first time +- [ ] **Breach review** — approved SP has breached SLA thresholds +- [ ] **Periodic check** — routine re-verification of an approved SP + +> Some sections below are only required for breach reviews. These are marked _(breach review only)_. + +--- + ### SP Details - **SP ID:** - **SP Name (optional):** @@ -16,14 +26,19 @@ assignees: [] ### Review Trigger - **Time review started (UTC):** -- **Trigger condition:** - +- **Trigger:** + + + --- ### Metrics -**Failing metric(s):** + + + +**Metric(s):** - **Observed value(s):** @@ -34,7 +49,7 @@ assignees: [] --- -### Investigation Window +### Investigation Window _(breach review only)_ - **Investigation deadline (UTC):** - **Within maintenance window?** Yes / No @@ -42,16 +57,16 @@ assignees: [] ### Communication -- **SP notified?** Yes / No +- **SP notified / engaged?** Yes / No - **Channel used:** - **SP response (if any):** - + --- -### Diagnosis +### Diagnosis _(breach review only)_ **Current assessment:** - [ ] SP-side issue @@ -66,19 +81,25 @@ assignees: [] ### Outcome -- [ ] Recovered within investigation window -- [ ] Unapproved +- [ ] **Approved** — SP added to approved list _(new approval / periodic check)_ +- [ ] **Not approved** — SP did not meet requirements _(new approval)_ +- [ ] **Recovered** within investigation window _(breach review)_ +- [ ] **Unapproved** _(breach review)_ - **Decision time (UTC):** +- **Decision owner:** + --- ### Actions Taken +- [ ] SP newly approved - [ ] SP remained approved - [ ] SP unapproved - [ ] Follow-up issue created - [ ] Escalated +- [ ] Added to approved list / Notion record updated --- From 264596b1e4cae84dc385c596e61990ab06cc2e7d Mon Sep 17 00:00:00 2001 From: TippyFlits Date: Tue, 19 May 2026 15:18:00 +0100 Subject: [PATCH 3/3] Update sp-approval-review template with metrics Added thresholds and metrics for data storage and retrieval. --- .github/ISSUE_TEMPLATE/sp-approval-review.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/sp-approval-review.md b/.github/ISSUE_TEMPLATE/sp-approval-review.md index 85df07d..1e657b2 100644 --- a/.github/ISSUE_TEMPLATE/sp-approval-review.md +++ b/.github/ISSUE_TEMPLATE/sp-approval-review.md @@ -45,7 +45,12 @@ assignees: [] - **Threshold(s):** -- + +| Metric | Threshold | Minimum Sample Size | +|--------|-----------|---------------------| +| [Data Storage Success Rate](#data-storage-success-rate) | ≥ 97% | 200 | +| [Data Retention Fault Rate](#data-retention-fault-rate) | ≤ 0.2% | 500 | +| [Retrieval Success Rate](#retrieval-success-rate) | ≥ 97% | 200 | ---