-
Notifications
You must be signed in to change notification settings - Fork 1
feat: standardise SP approval review tracking with issue template #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
BigLep
merged 3 commits into
FilOzone:master
from
TippyFlitsUK:TippyFlitsUK-sp-approval-template
May 21, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| --- | ||
| name: SP Approval Review | ||
| about: Track an SP approval decision — new approval, breach review, or periodic check | ||
| title: "[SP Approval] f0xxxx" | ||
| labels: ["sp-approval-review"] | ||
| assignees: [] | ||
|
rjan90 marked this conversation as resolved.
|
||
| --- | ||
|
|
||
| ## SP Approval Review | ||
|
|
||
| ### Review Type | ||
|
|
||
| - [ ] **New approval** — SP is being approved for the first time | ||
| - [ ] **Breach review** — approved SP has breached SLA thresholds | ||
| - [ ] **Periodic check** — routine re-verification of an approved SP | ||
|
|
||
| > Some sections below are only required for breach reviews. These are marked _(breach review only)_. | ||
|
|
||
| --- | ||
|
|
||
| ### SP Details | ||
| - **SP ID:** | ||
| - **SP Name (optional):** | ||
|
|
||
| --- | ||
|
|
||
| ### Review Trigger | ||
| - **Time review started (UTC):** | ||
| - **Trigger:** | ||
| <!-- New approval: e.g. SP met sustained thresholds, requested approval --> | ||
| <!-- Breach review: e.g. Storage success <97%, Retrieval failures, Retention faults --> | ||
| <!-- Periodic check: e.g. Quarterly review, post-incident re-verification --> | ||
|
|
||
| --- | ||
|
|
||
| ### Metrics | ||
|
|
||
| <!-- For new approvals: record observed performance against thresholds. --> | ||
| <!-- For breach reviews: record the failing metric(s). --> | ||
|
|
||
| **Metric(s):** | ||
| - | ||
|
|
||
| **Observed value(s):** | ||
| - | ||
|
|
||
| **Threshold(s):** | ||
|
|
||
| | Metric | Threshold | Minimum Sample Size | | ||
| |--------|-----------|---------------------| | ||
| | [Data Storage Success Rate](#data-storage-success-rate) | ≥ 97% | 200 | | ||
| | [Data Retention Fault Rate](#data-retention-fault-rate) | ≤ 0.2% | 500 | | ||
| | [Retrieval Success Rate](#retrieval-success-rate) | ≥ 97% | 200 | | ||
|
|
||
| --- | ||
|
|
||
| ### Investigation Window _(breach review only)_ | ||
| - **Investigation deadline (UTC):** | ||
| - **Within maintenance window?** Yes / No | ||
|
|
||
| --- | ||
|
|
||
| ### Communication | ||
|
|
||
| - **SP notified / engaged?** Yes / No | ||
| - **Channel used:** | ||
| <!-- #pdp-endorsed-sp OR #fil-pdp-mainnet-launch --> | ||
|
|
||
| - **SP response (if any):** | ||
| <!-- Brief summary --> | ||
|
|
||
| --- | ||
|
|
||
| ### Diagnosis _(breach review only)_ | ||
|
|
||
| **Current assessment:** | ||
| - [ ] SP-side issue | ||
| - [ ] Dealbot / tooling issue | ||
| - [ ] Network / external issue | ||
| - [ ] Unknown | ||
|
|
||
| **Notes:** | ||
| <!-- What do we think is happening? --> | ||
|
|
||
| --- | ||
|
|
||
| ### Outcome | ||
|
|
||
| - [ ] **Approved** — SP added to approved list _(new approval / periodic check)_ | ||
| - [ ] **Not approved** — SP did not meet requirements _(new approval)_ | ||
| - [ ] **Recovered** within investigation window _(breach review)_ | ||
| - [ ] **Unapproved** _(breach review)_ | ||
|
|
||
| - **Decision time (UTC):** | ||
| - **Decision owner:** | ||
| <!-- The approver responsible for this decision --> | ||
|
|
||
| --- | ||
|
|
||
| ### Actions Taken | ||
|
|
||
| - [ ] SP newly approved | ||
| - [ ] SP remained approved | ||
| - [ ] SP unapproved | ||
| - [ ] Follow-up issue created | ||
| - [ ] Escalated | ||
| - [ ] Added to approved list / Notion record updated | ||
|
|
||
| --- | ||
|
|
||
| ### Links & Evidence | ||
|
|
||
| - Dashboard (spdash): | ||
| - Dealbot runs: | ||
| - Logs / errors: | ||
| - Related issues: | ||
|
|
||
| --- | ||
|
|
||
| ### Notes | ||
|
|
||
| <!-- Anything else useful for future reference --> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.