Skip to content

[18.0][IMP] rma_repair #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chafique-delli wants to merge 2 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][IMP] rma_repair #682

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b230c03
[IMP] rma_repair
chafique-delli Aug 4, 2025
7d8f10e
fix repair view to have only one under_warranty field
chafique-delli Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rma_repair/models/repair.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ class RepairOrder(models.Model):
rma_line_id = fields.Many2one(
comodel_name="rma.order.line", string="RMA", ondelete="restrict"
)
under_warranty = fields.Boolean(
rma_under_warranty = fields.Boolean(
string="Under Warranty",
related="rma_line_id.under_warranty",
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow Aug 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was making the repair one related to the linked RMA (at least that's the intention, I have not functionally checked). In case, we don't want to disconnect them, you should fix only the view and keep only one.

If what I describe above (have both fields related) does not work as one would expect, a refactor with proper compute methods might be needed.

)
5 changes: 4 additions & 1 deletion rma_repair/views/repair_view.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,11 @@
<field name="arch" type="xml">
<field name="tag_ids" position="after">
<field name="rma_line_id" />
<field name="under_warranty" />
<field name="rma_under_warranty" invisible="not rma_line_id" />
</field>
<xpath expr="//field[@name='under_warranty']" position="attributes">
<attribute name="invisible">rma_line_id</attribute>
</xpath>
</field>
</record>
</odoo>