Fix detach race condition (#43)

* Fix detach race condition

pxThread->xAttr.usSchedPriorityDetachState may be changed by
pthread_detach(). Suspend scheduler to prevent race condition.

Signed-off-by: wangfei_chen <[email protected]>

* Fix compiler warnings

---------

Signed-off-by: wangfei_chen <[email protected]>
Co-authored-by: wangfei_chen <[email protected]>
Co-authored-by: Rahul Kar <[email protected]>

Author: 3 people

FreeRTOS-Plus-POSIX/source/FreeRTOS_POSIX_pthread.c

@@ -101,17 +101,21 @@ static void prvExitThread( void )
 {
     pthread_internal_t * pxThread = ( pthread_internal_t * ) pthread_self();
 
+    vTaskSuspendAll();
+
     /* If this thread is joinable, wait for a call to pthread_join. */
     if( pthreadIS_JOINABLE( pxThread->xAttr.usSchedPriorityDetachState ) )
     {
         ( void ) xSemaphoreGive( ( SemaphoreHandle_t ) &pxThread->xJoinBarrier );
+        ( void ) xTaskResumeAll();
 
         /* Suspend until the call to pthread_join. The caller of pthread_join
          * will perform cleanup. */
         vTaskSuspend( NULL );
     }
     else
     {
+        ( void ) xTaskResumeAll();
         /* For a detached thread, perform cleanup of thread object. */
         vPortFree( pxThread );
         vTaskDelete( NULL );
@@ -359,7 +363,7 @@ int pthread_create( pthread_t * thread,
         }
 
         /* End the critical section. */
-        xTaskResumeAll();
+        ( void ) xTaskResumeAll();
     }
 
     return iStatus;
@@ -467,7 +471,7 @@ int pthread_join( pthread_t pthread,
         vPortFree( pxThread );
 
         /* End the critical section. */
-        xTaskResumeAll();
+        ( void ) xTaskResumeAll();
     }
 
     return iStatus;
@@ -526,7 +530,7 @@ int pthread_detach(pthread_t pthread)
         }
 
         /* End the critical section. */
-        xTaskResumeAll();
+        ( void ) xTaskResumeAll();
     }
 
     return iStatus;