-
-
Notifications
You must be signed in to change notification settings - Fork 10
feat: implement permission change for selecting own post #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BHZoon
wants to merge
12
commits into
FriendsOfFlarum:1.x
Choose a base branch
from
glowingblue:bh/select-own-best-answer-by-permission
base: 1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2796b6f
feat: implement permission change for selecting own post
BHZoon 70eee3c
fix: code styling
BHZoon 5443208
fix: code styling
BHZoon 46dcab3
fix: code styling
BHZoon 070667d
fix: code styling
BHZoon 9e4ad62
chore: cleanup dependencies, fix types and formatting
BHZoon b447dee
style: add trailing commas in integration test
BHZoon 2fc59d3
style: fix spacing after type cast in test
BHZoon 2c08dc3
style: add newline at end of file
BHZoon 30fdc8b
fix: check if specific post can be selected as best answer
BHZoon f414ace
refactor: rename canSelectBestAnswer to canSelectAsBestAnswer
BHZoon c3f5438
fix: correct attribute name in extend.ts and update dist
BHZoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's discouraged to commit
distfiles, this is automatically taken care of by CI. See https://docs.flarum.org/contributing/#setting-up-a-local-codebase