chore: refactor task builder, better naming and documentation

Author: toresbe

app/api/hooks/metadata.py

@@ -7,7 +7,7 @@
 
 from app.api.hooks.schema.request import HookRequest
 from app.media.ffprobe_schema import FfprobeOutput
-from app.task_builder import TKB
+from app.task_builder import build_task
 
 logger = logging.getLogger(__name__)
 
@@ -33,7 +33,7 @@ class MetadataExtractor:
     """Class to handle metadata extraction and compliance checking."""
 
     async def _run_ffprobe(self, filepath: Path) -> str:
-        stdout, _ = await TKB(
+        stdout, _ = await build_task(
             f"ffprobe -v quiet -show_format -show_streams -of json {shlex.quote(str(filepath))}"
         ).execute()
         return stdout

app/ingest.py

@@ -8,7 +8,7 @@
 from .archive_store import Archive
 from .media.comand_template import ProfileTemplateArguments, TemplatedCommandGenerator
 from .media.ffprobe_schema import FfprobeOutput
-from .task_builder import TKB
+from .task_builder import build_task
 
 DESIRED_FORMATS = (
     FormatEnum.LARGE_THUMB,
@@ -90,7 +90,7 @@ async def _process_format(
         command = template.render(template_args)
         self.logger.debug("Generated command: %s", command)
 
-        await TKB(command).execute()
+        await build_task(command).execute()
 
         self.logger.info("Creating video file entry for %s", output_file)
         await self.django_api.create_video_file(filename=str(output_file), file_format=file_format, video_id=video_id)

app/task_builder.py

@@ -1,23 +1,14 @@
-import asyncio
+"""RSX-11M for life"""
 
-from app.runner import Task
+from asyncio import create_subprocess_shell, subprocess
 
+from app.runner import Task
 
-def TKB(command: str) -> Task:
-    """Task Builder for running subprocesses asynchronously. The name is a reference to RSX-11M+ :)
 
-    This function takes a command string, splits it into arguments, and creates a Task
-    that can be executed asynchronously. It uses asyncio's subprocess capabilities to
-    run the command in a subprocess, capturing both stdout and stderr.
+def build_task(shell_command: str) -> Task:
+    """Creates a Task to run a shell command asynchronously.
 
     Args:
-        command (str): The shell command to run.
-
+        shell_command (str): The shell command to run.
     """
-    return Task(
-        asyncio.create_subprocess_shell(
-            command,
-            stdout=asyncio.subprocess.PIPE,
-            stderr=asyncio.subprocess.PIPE,
-        )
-    )
+    return Task(create_subprocess_shell(shell_command, stdout=subprocess.PIPE, stderr=subprocess.PIPE))

tests/test_runner.py

@@ -1,6 +1,6 @@
 import pytest
 
-from app.task_builder import TKB
+from app.task_builder import build_task
 
 
 @pytest.mark.asyncio
@@ -9,6 +9,6 @@ async def test_basic_run(tmp_path):
     test_path.touch()
     assert test_path.exists()
 
-    await TKB(f"rm {test_path}").execute()
+    await build_task(f"rm {test_path}").execute()
 
     assert not test_path.exists()