Skip to content

Fix culling frustum to use correct FOV #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix culling frustum to use correct FOV #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/render/shaders/prepare_views.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,12 @@ void main(uint3 tid : SV_DispatchThreadID,
float3 up = rotateVec(qInv,float3(0, 0, 1));
float3 right = cross(front,up);

float zFar = 20000; //Dummy value for now
float aspectRatio = view_data.yScale/view_data.xScale;
float farPlaneHalfHeight = zFar; //Assumed fov of 90
float farDist = view_data.zFar;
float aspectRatio = view_data.yScale / view_data.xScale;
float tanHalfVert = 1.0f / -view_data.yScale;
float farPlaneHalfHeight = farDist * tanHalfVert;
float farPlaneHalfWidth = farPlaneHalfHeight * aspectRatio;
float3 farVec = zFar * front;
float3 farVec = farDist * front;

sm.nearPlane = float4(front,dot(-front,view_data.pos+view_data.zNear*front));
sm.farPlane = float4(-front,dot(front,view_data.pos+farVec));
Expand Down