Skip to content

Enable Public and Approved options only when ADW is activated #2219

@giohappy

Description

@giohappy

A recurrent question is why the "Public" and "Approved" options do not seem to affect resource visibility.
The question is legit because they actually do not affect visibility unless the ADW options are activated.
The options are RESOURCE_PUBLISHING and ADMIN_MODERATE_UPLOADS, which are False by default.

The combinations of these options activate distinct (and very specific) behaviours that go behind the generic term of "Advanced Workflow". You can read about the ADW here and an active discussion in GNIP 103.

Back to the "Public" and "Approved" options, they do not affect visibility or permissions directly, even when the ADW is activated. What they do is driving "state transitions" when the resource is saved. If the two options are changed when a resource is saved, a set of side effects is triggered, including automatic changes to the permissions of users and groups, depending on their roles and the combinations of the ADW settings.
This is pretty complicated and hard to follow, and this is one of the reasons we're proposing to deprecate the current ADW implementation in favour of a simpler logic.

Aside from the discussion on ADW itself, we think the "Public" and "Approved" should be available only when they make sense, i.e., when ADW is active. Specifically, the proposal is to:

  • make the "Published" options available only if RESOURCE_PUBLISHING is True
  • make the "Approved" options available only if ADMIN_MODERATE_UPLOADS is True

It will help clarify their (current) role.

Metadata

Metadata

Assignees

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions