Skip to content

Commit f53b942

Browse files
committed
[Fixes #13800] Refact metadata i18n mechanism - gemini fixes
1 parent 0524a81 commit f53b942

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

geonode/base/i18n.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def get_entry(self, lang, data_key):
8787
date is needed for checking the entry freshness when setting info
8888
data may be None if not cached or expired
8989
"""
90-
cached_entry = self.lang_cache.get(lang, None)
90+
cached_entry: I18nCacheEntry = self.lang_cache.get(lang, None)
9191

9292
# TODO: thesaurus date check should be done only after a given time interval from last check
9393
thesaurus_date = ( # may be none if thesaurus does not exist
@@ -96,7 +96,7 @@ def get_entry(self, lang, data_key):
9696
if cached_entry:
9797
if thesaurus_date == cached_entry.date:
9898
# only return cached data if thesaurus has not been modified
99-
return thesaurus_date, cached_entry.get(data_key, None)
99+
return thesaurus_date, cached_entry.caches.get(data_key, None)
100100
else:
101101
logger.info(f"Schema for {lang}:{data_key} needs to be recreated")
102102

geonode/metadata/tests/tests.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131

3232
from rest_framework.test import APITestCase
3333
from geonode.metadata.settings import MODEL_SCHEMA
34-
from geonode.metadata.manager import metadata_manager, CONTEXT_KEY_LABELS
34+
from geonode.metadata.manager import metadata_manager, CONTEXT_KEY_LABELS, CACHE_KEY_SCHEMA
3535
from geonode.base.i18n import I18nCache
3636
from geonode.metadata.api.views import (
3737
ProfileAutocomplete,
@@ -851,7 +851,7 @@ def test_get_schema(self, mock_get_entry, mock_set, mock_build_schema):
851851
mock_get_entry.return_value = (thesaurus_date, expected_schema)
852852
result = metadata_manager.get_schema(lang)
853853

854-
mock_get_entry.assert_called_once_with(str(lang), I18nCache.CACHE_KEY_SCHEMA)
854+
mock_get_entry.assert_called_once_with(str(lang), CACHE_KEY_SCHEMA)
855855
mock_build_schema.assert_not_called()
856856
mock_set.assert_not_called()
857857
self.assertEqual(result, expected_schema)
@@ -867,9 +867,9 @@ def test_get_schema(self, mock_get_entry, mock_set, mock_build_schema):
867867

868868
result = metadata_manager.get_schema(lang)
869869

870-
mock_get_entry.assert_called_once_with(str(lang), I18nCache.CACHE_KEY_SCHEMA)
870+
mock_get_entry.assert_called_once_with(str(lang), CACHE_KEY_SCHEMA)
871871
mock_build_schema.assert_called_once_with(lang)
872-
mock_set.assert_called_once_with(str(lang), I18nCache.CACHE_KEY_SCHEMA, expected_schema, thesaurus_date)
872+
mock_set.assert_called_once_with(str(lang), CACHE_KEY_SCHEMA, expected_schema, thesaurus_date)
873873
self.assertEqual(result, expected_schema)
874874

875875
@patch("geonode.metadata.manager.metadata_manager.get_schema")

0 commit comments

Comments
 (0)