Skip to content

Commit 5c38190

Browse files
authored
extend and document PublishOption (#872)
* extend and document PublishOption * fix bitrate
1 parent 5ce5d7a commit 5c38190

File tree

6 files changed

+801
-735
lines changed

6 files changed

+801
-735
lines changed

protobuf/video/sfu/event/events.pb.go

Lines changed: 344 additions & 344 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

protobuf/video/sfu/event/events.proto

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,8 @@ message SfuEvent {
7777
ParticipantUpdated participant_updated = 24;
7878
// ParticipantMigrationComplete is sent when the participant migration is complete
7979
ParticipantMigrationComplete participant_migration_complete = 25;
80-
// CodecNegotiationComplete is sent to signal the completion of a codec negotiation.
81-
// SDKs can safely stop previous transceivers
82-
CodecNegotiationComplete codec_negotiation_complete = 26;
80+
// ChangePublishOptionsComplete is sent to signal the completion of a ChangePublishOptions request.
81+
ChangePublishOptionsComplete change_publish_options_complete = 26;
8382
// ChangePublishOptions is sent to signal the change in publish options such as a new codec or simulcast layers
8483
ChangePublishOptions change_publish_options = 27;
8584
}
@@ -89,12 +88,10 @@ message ChangePublishOptions {
8988
models.PublishOption publish_option = 1;
9089
}
9190

92-
message CodecNegotiationComplete {
93-
91+
message ChangePublishOptionsComplete {
9492
}
9593

9694
message ParticipantMigrationComplete{
97-
9895
}
9996

10097
message PinsChanged {

protobuf/video/sfu/event/events_vtproto.pb.go

Lines changed: 19 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)