-
Notifications
You must be signed in to change notification settings - Fork 64
dependabot: try enabling cooldown again #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR re-enables the Dependabot cooldown feature that was previously attempted in PR #342. It adds a 4-day cooldown period (the minimum required by Zizmor) to prevent Dependabot from creating too many PRs in rapid succession when new dependency versions are released.
- Adds
cooldownconfiguration withdefault-days: 4to all package ecosystems - Addresses previous issues that may have been fixed in recent Dependabot updates
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth trying again. We'll need to monitor when the jobs run. Last time they kept showing no updates after filtering.
woodruffw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've been considering increasing the minimum default cooldown in zizmor to 7 days, so you might want to get ahead of that here (or configure it explicitly so you don't get nagged).
👍🏻 to me to do 7 days. |
|
Updated to 7 days. Unrelated to this, but not sure if Terraform section is doing anything, at least after repo merge, as the directory layout changed. |
May want to try this again to see what is state of cooldown feature since previous attempt
For now, using minimum requirement expected by Zizmor (i.e. 4 days)
Supposedly should default to all files without
includebut not sure given it didn't work last time.I see fixes like dependabot/dependabot-core@7da4bdd which could help as it may have used semver-major-days (14 previously configured) for all Bundler updates,