@@ -235,7 +235,6 @@ describe('DatasetsRepository', () => {
235235 false
236236 )
237237 expect ( actual . id ) . toBe ( testDatasetIds . numericId )
238- expect ( actual . internalVersionNumber ) . toBe ( 1 )
239238 } )
240239
241240 test ( 'should return dataset when it is deaccessioned and includeDeaccessioned param is set' , async ( ) => {
@@ -1132,8 +1131,8 @@ describe('DatasetsRepository', () => {
11321131 }
11331132 ] )
11341133 } )
1135- // TODO: add this test when https://github.com/IQSS/dataverse-client-javascript/issues/343 is fixed
1136- test . skip ( 'should throw error if trying to update an outdated internal version dataset ' , async ( ) => {
1134+
1135+ test ( 'should throw error if sending an outdated lastUpdateTime ' , async ( ) => {
11371136 const testDataset = {
11381137 metadataBlockValues : [
11391138 {
@@ -1184,43 +1183,35 @@ describe('DatasetsRepository', () => {
11841183 false ,
11851184 false
11861185 )
1187- const actualCreatedDatasetInternalVersionNumber = actualCreatedDataset . internalVersionNumber
1188-
1189- expect ( actualCreatedDataset . internalVersionNumber ) . toBe ( 1 )
1186+ const firstLastUpdateTime = actualCreatedDataset . versionInfo . lastUpdateTime
11901187
1191- // Now update the dataset and then update again with the same internal version number
1188+ // Now update the dataset and then update again with the same source last update time
11921189 const updatedDsDescription = 'This is the updated description of the dataset.'
11931190 testDataset . metadataBlockValues [ 0 ] . fields . dsDescription [ 0 ] . dsDescriptionValue =
11941191 updatedDsDescription
11951192
1196- // First update sending the correct internal version number
1193+ // Wait for 2 seconds
1194+ await new Promise ( ( resolve ) => setTimeout ( resolve , 2000 ) )
1195+
1196+ // First update sending the correct lastUpdateTime
11971197 await sut . updateDataset (
11981198 createdDataset . numericId ,
11991199 testDataset ,
12001200 [ citationMetadataBlock ] ,
1201- actualCreatedDatasetInternalVersionNumber
1202- )
1203-
1204- const afterFirstUpdateDataset = await sut . getDataset (
1205- createdDataset . numericId ,
1206- DatasetNotNumberedVersion . LATEST ,
1207- false ,
1208- false
1201+ firstLastUpdateTime
12091202 )
12101203
1211- expect ( afterFirstUpdateDataset . internalVersionNumber ) . toBe ( 2 )
1212-
1213- //Now try to update again with the previous internal version number
1204+ //Now try to update again with the previous lastUpdateTime
12141205 const expectedError = new WriteError (
1215- `[400] Dataset internal version number ${ actualCreatedDatasetInternalVersionNumber } is outdated`
1206+ `[400] Internal version timestamp ${ firstLastUpdateTime } is outdated`
12161207 )
12171208
12181209 await expect (
12191210 sut . updateDataset (
12201211 createdDataset . numericId ,
12211212 testDataset ,
12221213 [ citationMetadataBlock ] ,
1223- actualCreatedDatasetInternalVersionNumber
1214+ firstLastUpdateTime
12241215 )
12251216 ) . rejects . toThrow ( expectedError )
12261217 } )
0 commit comments