Skip to content

Commit b2586e9

Browse files
fix: update project template environment handling to use nullish instead of optional
1 parent ceb8761 commit b2586e9

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

backend/src/ee/routes/v1/project-template-router.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ export const registerProjectTemplateRouter = async (server: FastifyZodProvider)
197197
description: z.string().max(256).trim().optional().describe(ProjectTemplates.CREATE.description),
198198
roles: ProjectTemplateRolesSchema.default([]).describe(ProjectTemplates.CREATE.roles),
199199
type: z.nativeEnum(ProjectType).describe(ProjectTemplates.CREATE.type),
200-
environments: ProjectTemplateEnvironmentsSchema.optional().describe(ProjectTemplates.CREATE.environments)
200+
environments: ProjectTemplateEnvironmentsSchema.nullish().describe(ProjectTemplates.CREATE.environments)
201201
}),
202202
response: {
203203
200: z.object({
@@ -242,7 +242,7 @@ export const registerProjectTemplateRouter = async (server: FastifyZodProvider)
242242
.describe(ProjectTemplates.UPDATE.name),
243243
description: z.string().max(256).trim().optional().describe(ProjectTemplates.UPDATE.description),
244244
roles: ProjectTemplateRolesSchema.optional().describe(ProjectTemplates.UPDATE.roles),
245-
environments: ProjectTemplateEnvironmentsSchema.optional().describe(ProjectTemplates.UPDATE.environments)
245+
environments: ProjectTemplateEnvironmentsSchema.nullish().describe(ProjectTemplates.UPDATE.environments)
246246
}),
247247
response: {
248248
200: z.object({

backend/src/ee/services/project-template/project-template-service.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,11 +189,15 @@ export const projectTemplateServiceFactory = ({
189189
message: `A project template with the name "${params.name}" already exists.`
190190
});
191191

192+
const projectTemplateEnvironments =
193+
type === ProjectType.SecretManager && environments === undefined
194+
? ProjectTemplateDefaultEnvironments
195+
: environments;
196+
192197
const projectTemplate = await projectTemplateDAL.create({
193198
...params,
194199
roles: JSON.stringify(roles.map((role) => ({ ...role, permissions: packRules(role.permissions) }))),
195-
environments:
196-
type === ProjectType.SecretManager ? JSON.stringify(environments ?? ProjectTemplateDefaultEnvironments) : null,
200+
environments: JSON.stringify(projectTemplateEnvironments),
197201
orgId: actor.orgId,
198202
type
199203
});

0 commit comments

Comments
 (0)