File tree Expand file tree Collapse file tree 1 file changed +3
-1
lines changed
backend/src/ee/services/pki-acme Expand file tree Collapse file tree 1 file changed +3
-1
lines changed Original file line number Diff line number Diff line change @@ -769,7 +769,9 @@ export const pkiAcmeServiceFactory = ({
769769 const cert = await orderCertificate (
770770 {
771771 caId : certificateAuthority ! . id ,
772- commonName : certificateRequest . commonName ! ,
772+ // It is possible that the CSR does not have a common name, in which case we use an empty string
773+ // (more likely than not for a CSR from a modern ACME client like certbot, cert-manager, etc.)
774+ commonName : certificateRequest . commonName ?? "" ,
773775 altNames : certificateRequest . subjectAlternativeNames ?. map ( ( san ) => san . value ) ,
774776 csr : Buffer . from ( csrPem ) ,
775777 // TODO: not 100% sure what are these columns for, but let's put the values for common website SSL certs for now
You can’t perform that action at this time.
0 commit comments