-
Notifications
You must be signed in to change notification settings - Fork 1.6k
pam: allow account credentials to be fetched more than once #4905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Greptile Summary
Confidence Score: 5/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
backend/src/ee/services/pam-account/pam-account-service.ts, line 667-669 (link)logic: The security check for expired sessions doesn't consider sessions in
Activestate. With repeated credential fetches now allowed, there's no verification that the session hasn't been administratively terminated (Terminatedstatus) or ended by user (Endedstatus) between the initial fetch and subsequent fetches.Attack scenario: If an admin terminates a session or user ends it, the gateway can still repeatedly fetch credentials using the old sessionId, as only
endedAtandexpiresAtare checked, not thestatusfield.Check the session status explicitly:
1 file reviewed, 2 comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
|
@greptile review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
pam: allow account credentials to be fetched more than once
Creates new audit log type for specifically accessing credentials